All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Xu, Yang" <raphael-xu@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"tiwai@suse.com" <tiwai@suse.com>,
	"Ding, Shenghao" <shenghao-ding@ti.com>
Subject: Re: [PATCH 1/4] Asoc: tas2764 : new tas27xx driver to support either tas2764 or tas2780
Date: Tue, 15 Mar 2022 10:12:49 +0100	[thread overview]
Message-ID: <s5hee33a8a6.wl-tiwai@suse.de> (raw)
In-Reply-To: <51482fa1bb6d4b96abbd42991f7d492b@ti.com>

On Tue, 15 Mar 2022 06:28:05 +0100,
Xu, Yang wrote:
> 
> Hi Mark and Takashi Iwai,
> 
> This is Raphael Xu who is from Low Power Audio team,Texas Instrument.
> 
> Could you help to review the attached patch and upstream them to the kernel?

Thanks for the patches, but could you prepare the proper patches and
submit in a better way?  The details about how to submit patches are
found in Documentation/process/submitting-patches.rst.

It seems that you sent a diff from each file, but it's no proper
patch.  I guess it'll be a single patch containing all files in your
case.

Also, above all, describe why and what you added / modified the code
concisely but well understandably in the patch description (commit
log).

Drop the kernel version check with #if LINUX_VERSION.  This must not
be in the upstream code.

Last but not least, don't forget to put your Signed-off-by tag.  It's
a legal requirement.  Again, see the document above for details.


thanks,

Takashi

      reply	other threads:[~2022-03-15  9:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-15  5:28 [PATCH 1/4] Asoc: tas2764 : new tas27xx driver to support either tas2764 or tas2780 Xu, Yang
2022-03-15  9:12 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hee33a8a6.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=raphael-xu@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.