From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C235C636CE for ; Wed, 21 Jul 2021 14:05:05 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93DC36124B for ; Wed, 21 Jul 2021 14:05:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93DC36124B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1370116EC; Wed, 21 Jul 2021 16:04:13 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1370116EC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626876303; bh=4Et3XZRbaOpRph7bVqwBp7KgnW1cBPP7lRhB4nZb+Z0=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=dhoGrKAc12btzZIL5YueZMie4kCm8ovQjQ0Dy3KEjpU1tuxOHo3MerTgmAGnLi9qk bHpuc18/4ykKujsc+kEdgwV9knnSo1mbB9BmL69O/kN1QIX+tPMukC3bChF1Kp87ah SlpUeMmIry+CnfiDgmUOHWi0F6K0ZKYOqDZE1UqU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AE4B6F804AB; Wed, 21 Jul 2021 16:04:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 12102F804AC; Wed, 21 Jul 2021 16:04:12 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D92E4F800FD for ; Wed, 21 Jul 2021 16:04:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D92E4F800FD Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="WSGqcjGO"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="epxNEq9Z" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 53D4422542; Wed, 21 Jul 2021 14:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626876243; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s9o5gw9ee0BD/0Um0CZpQOb6GDHM/3tjfz/lIISVRp4=; b=WSGqcjGOyZEsx6Msf22k8vBCsvlqjB1aMEC+ueHQAA6GBdDMcYCaDT27zTsKALJdGMqlLp X2BXa6xBXJggy9+hLHpOSYCtb+qz26ajjD6CcpVHD1gw6eFrwiGpoSMVLKngqsO+zsE/rT hBwGuZxouGBZ3c/ZKRCfWZdeDhu5xMw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626876243; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s9o5gw9ee0BD/0Um0CZpQOb6GDHM/3tjfz/lIISVRp4=; b=epxNEq9ZSIqRgjr4zKxlLV7S9yYYHwkZ7xYZG1bT186rj4q/B7vGzhZMQ3UQUzBcm+SC6V 0N2EI5GsVBB8SNBA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3E053A3B84; Wed, 21 Jul 2021 14:04:03 +0000 (UTC) Date: Wed, 21 Jul 2021 16:04:03 +0200 Message-ID: From: Takashi Iwai To: Dan Carpenter Subject: Re: [PATCH] ALSA: korg1212: Fix crash in snd_korg1212_create() In-Reply-To: <20210721140122.GA5251@kili> References: <20210721140122.GA5251@kili> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Leon Romanovsky X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 21 Jul 2021 16:01:22 +0200, Dan Carpenter wrote: > > The "dsp_code" is not initialized until the next line so we can't > dereference it. > > Fixes: b5cde369b618 ("ALSA: korg1212: Allocate resources with device-managed APIs") > Signed-off-by: Dan Carpenter Thanks, it's already addressed by commit d364a600d6ed. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9532CC12002 for ; Wed, 21 Jul 2021 14:04:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 769A06124B for ; Wed, 21 Jul 2021 14:04:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237827AbhGUNX1 (ORCPT ); Wed, 21 Jul 2021 09:23:27 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:50076 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236733AbhGUNX1 (ORCPT ); Wed, 21 Jul 2021 09:23:27 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 53D4422542; Wed, 21 Jul 2021 14:04:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626876243; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s9o5gw9ee0BD/0Um0CZpQOb6GDHM/3tjfz/lIISVRp4=; b=WSGqcjGOyZEsx6Msf22k8vBCsvlqjB1aMEC+ueHQAA6GBdDMcYCaDT27zTsKALJdGMqlLp X2BXa6xBXJggy9+hLHpOSYCtb+qz26ajjD6CcpVHD1gw6eFrwiGpoSMVLKngqsO+zsE/rT hBwGuZxouGBZ3c/ZKRCfWZdeDhu5xMw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626876243; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s9o5gw9ee0BD/0Um0CZpQOb6GDHM/3tjfz/lIISVRp4=; b=epxNEq9ZSIqRgjr4zKxlLV7S9yYYHwkZ7xYZG1bT186rj4q/B7vGzhZMQ3UQUzBcm+SC6V 0N2EI5GsVBB8SNBA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 3E053A3B84; Wed, 21 Jul 2021 14:04:03 +0000 (UTC) Date: Wed, 21 Jul 2021 16:04:03 +0200 Message-ID: From: Takashi Iwai To: Dan Carpenter Cc: Jaroslav Kysela , Takashi Iwai , Leon Romanovsky , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: korg1212: Fix crash in snd_korg1212_create() In-Reply-To: <20210721140122.GA5251@kili> References: <20210721140122.GA5251@kili> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Wed, 21 Jul 2021 16:01:22 +0200, Dan Carpenter wrote: > > The "dsp_code" is not initialized until the next line so we can't > dereference it. > > Fixes: b5cde369b618 ("ALSA: korg1212: Allocate resources with device-managed APIs") > Signed-off-by: Dan Carpenter Thanks, it's already addressed by commit d364a600d6ed. Takashi