From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94DF0C07E95 for ; Tue, 13 Jul 2021 16:08:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C11F961164 for ; Tue, 13 Jul 2021 16:08:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C11F961164 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3CCE51675; Tue, 13 Jul 2021 18:08:01 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3CCE51675 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1626192531; bh=Enx2C/qeyb7Ah1ShHkRM3zxtZc3o8X6Y8WmhxyoagKA=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=KAWckkNws3lgslA7Dc8j6KWmjuGNj8wQ0NgjlDq/SRziV6fQqhPnALr7Y5/uHHRWu g/mdQW+V273KnXwzqhBz8SeAzZXAcA23nb288b+BeaB9hGpiYfib6C8xQUcTHaGftY YR6JnSagxAkn7AJTpVTB+nnHNhKPMpwluOM8CPOc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D5E94F8020C; Tue, 13 Jul 2021 18:08:00 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E17B7F80217; Tue, 13 Jul 2021 18:07:58 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AF01EF800ED for ; Tue, 13 Jul 2021 18:07:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AF01EF800ED Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="bpuKcxEs"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="cB45TT2l" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id C0C2B201FA; Tue, 13 Jul 2021 16:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1626192475; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=onaD3uM5AtnYexO9vckWln2jRhqLEOBldPaL6VGWFeE=; b=bpuKcxEsLY+6wAjT752fnvLSclMnE+lefFCphlf/JxmEBvanhO0jZMhF8MPV+0JfbOz7C1 zP17hYTcvZ428Pf+Gy1jpzhsmdEQ7L2n7KyiBt3kaRrz/DEWKnESHHsR1Zy0taXq/l6R0e 4imzB8F7OtugAG+dOgZO5D9LFDK0CAU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1626192475; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=onaD3uM5AtnYexO9vckWln2jRhqLEOBldPaL6VGWFeE=; b=cB45TT2lYZFKUG0i4vBMf3eB+hC9ZTGs1gXN8cUVN0zG5PUB/NawMG0kLEXJN5p4TUeQzJ ElM5/UmlTjgZcCBA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id B8CF8A3B88; Tue, 13 Jul 2021 16:07:55 +0000 (UTC) Date: Tue, 13 Jul 2021 18:07:55 +0200 Message-ID: From: Takashi Iwai To: Amadeusz SX2awiX4ski Subject: Re: [PATCH 15/51] ALSA: ens137x: Allocate resources with device-managed APIs In-Reply-To: References: <20210713142857.19654-1-tiwai@suse.de> <20210713142857.19654-16-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 13 Jul 2021 17:23:26 +0200, Amadeusz SX2awiX4ski wrote: > > On 7/13/2021 4:28 PM, Takashi Iwai wrote: > > This patch converts the resource management in PCI esn137x drivers > > with devres as a clean up. Each manual resource management is > > converted with the corresponding devres helper, the devres helper is > > used for the DMA buffer page allocations, and the card object release > > is managed now via card->private_free instead of a lowlevel > > snd_device. > > > > This should give no user-visible functional changes. > > > > Signed-off-by: Takashi Iwai > > --- > > sound/pci/ens1370.c | 115 +++++++++++--------------------------------- > > 1 file changed, 27 insertions(+), 88 deletions(-) > > > > diff --git a/sound/pci/ens1370.c b/sound/pci/ens1370.c > > index 728b69dad21b..2651f0c64c06 100644 > > --- a/sound/pci/ens1370.c > > +++ b/sound/pci/ens1370.c > > @@ -414,7 +414,7 @@ struct ensoniq { > > unsigned int spdif_stream; > > #ifdef CHIP1370 > > - struct snd_dma_buffer dma_bug; > > + struct snd_dma_buffer *dma_bug; > > > You seem to touch all uses of this variable and it seems like it has a > typo (dma_bug -> dms_buf), Really? I couldn't find it. Takashi