From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D742AC49EA7 for ; Fri, 25 Jun 2021 07:46:48 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 147736141C for ; Fri, 25 Jun 2021 07:46:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 147736141C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9F2D31658; Fri, 25 Jun 2021 09:45:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9F2D31658 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1624607206; bh=SJ/ttXWnScFDc1gltvFsRoRiUzNfFe65z/tqc5DEqWg=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=leG426f6Q41kPD+UO7ZOEQKzBzsLAsHByfGLOj8pOq63y6cXDSxU/PbVqvKoRzLfq 6NjM9Dy4ZC66dclbn2098mxk8tnRYZkR8ZiXL5kvBahVeo1+RMwzs0PG/W+d/BRAqO lS9hQpQrkPCRAAdbBpBDdAMvC2/0EyWew6Qj+L+Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3CD99F8016D; Fri, 25 Jun 2021 09:45:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6C532F801D5; Fri, 25 Jun 2021 09:45:54 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 13769F80137 for ; Fri, 25 Jun 2021 09:45:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 13769F80137 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="M7+xz/a9"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="EtUjCLjs" Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D16311FE44; Fri, 25 Jun 2021 07:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624607148; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=36BBIWb4P8ecW+8XwIEeqQKz0t/gusqeVesShI9xHg0=; b=M7+xz/a9TmUqCSkYQHb4RVL9tzw03KTkHSoR3+JKfQOnbCM8PPx+cn1HHkjaSnW6tFqadc tSDBvRQ2vs9KGlkBzARbA7CPJ2v6CSo/0BCRsdvQKi3BG9Mk3mn+EGnKq8+NNxd7hv97ID vawBPfjSr47XnvLcBlD2cati2yEi2us= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624607148; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=36BBIWb4P8ecW+8XwIEeqQKz0t/gusqeVesShI9xHg0=; b=EtUjCLjsxXowRPDAuCz+/1wLBZE7ZynZhCPIPK0jLc3vl4i+EMwMmj/2wVREteU32LjdYg XWdevm9xEb6kV5CA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id BBF10A3BB4; Fri, 25 Jun 2021 07:45:48 +0000 (UTC) Date: Fri, 25 Jun 2021 09:45:48 +0200 Message-ID: From: Takashi Iwai To: Nathan Chancellor Subject: Re: [PATCH] ALSA: usb-audio: scarlett2: Fix for loop increment in scarlett2_usb_get_config In-Reply-To: <20210624212048.1356136-1-nathan@kernel.org> References: <20210624212048.1356136-1-nathan@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Takashi Iwai , clang-built-linux@googlegroups.com, "Geoffrey D. Bennett" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 24 Jun 2021 23:20:48 +0200, Nathan Chancellor wrote: > > Clang warns: > > sound/usb/mixer_scarlett_gen2.c:1189:32: warning: expression result > unused [-Wunused-value] > for (i = 0; i < count; i++, (u16 *)buf++) > ^ ~~~~~ > 1 warning generated. > > It appears the intention was to cast the void pointer to a u16 pointer > so that the data could be iterated through like an array of u16 values. > However, the cast happens after the increment because a cast is an > rvalue, whereas the post-increment operator only works on lvalues, so > the loop does not iterate as expected. > > Replace the post-increment shorthand with the full expression so the > cast can be added in the right place and the look works as expected. > > Fixes: ac34df733d2d ("ALSA: usb-audio: scarlett2: Update get_config to do endian conversion") > Link: https://github.com/ClangBuiltLinux/linux/issues/1408 > Signed-off-by: Nathan Chancellor > --- > sound/usb/mixer_scarlett_gen2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c > index fcba682cd422..c20c7f1ddc50 100644 > --- a/sound/usb/mixer_scarlett_gen2.c > +++ b/sound/usb/mixer_scarlett_gen2.c > @@ -1186,7 +1186,7 @@ static int scarlett2_usb_get_config( > if (err < 0) > return err; > if (size == 2) > - for (i = 0; i < count; i++, (u16 *)buf++) > + for (i = 0; i < count; i++, buf = (u16 *)buf + 1) > *(u16 *)buf = le16_to_cpu(*(__le16 *)buf); That's still too error-prone. Could you rather introduce another variable of u16 * type, and use it instead? Ditto for u8 access for the code after that, too. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BF4CC2B9F4 for ; Fri, 25 Jun 2021 07:45:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FAEE6141C for ; Fri, 25 Jun 2021 07:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230004AbhFYHsK (ORCPT ); Fri, 25 Jun 2021 03:48:10 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:55136 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229671AbhFYHsJ (ORCPT ); Fri, 25 Jun 2021 03:48:09 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id D16311FE44; Fri, 25 Jun 2021 07:45:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624607148; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=36BBIWb4P8ecW+8XwIEeqQKz0t/gusqeVesShI9xHg0=; b=M7+xz/a9TmUqCSkYQHb4RVL9tzw03KTkHSoR3+JKfQOnbCM8PPx+cn1HHkjaSnW6tFqadc tSDBvRQ2vs9KGlkBzARbA7CPJ2v6CSo/0BCRsdvQKi3BG9Mk3mn+EGnKq8+NNxd7hv97ID vawBPfjSr47XnvLcBlD2cati2yEi2us= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624607148; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=36BBIWb4P8ecW+8XwIEeqQKz0t/gusqeVesShI9xHg0=; b=EtUjCLjsxXowRPDAuCz+/1wLBZE7ZynZhCPIPK0jLc3vl4i+EMwMmj/2wVREteU32LjdYg XWdevm9xEb6kV5CA== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id BBF10A3BB4; Fri, 25 Jun 2021 07:45:48 +0000 (UTC) Date: Fri, 25 Jun 2021 09:45:48 +0200 Message-ID: From: Takashi Iwai To: Nathan Chancellor Cc: "Geoffrey D. Bennett" , Jaroslav Kysela , Takashi Iwai , Nick Desaulniers , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH] ALSA: usb-audio: scarlett2: Fix for loop increment in scarlett2_usb_get_config In-Reply-To: <20210624212048.1356136-1-nathan@kernel.org> References: <20210624212048.1356136-1-nathan@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Jun 2021 23:20:48 +0200, Nathan Chancellor wrote: > > Clang warns: > > sound/usb/mixer_scarlett_gen2.c:1189:32: warning: expression result > unused [-Wunused-value] > for (i = 0; i < count; i++, (u16 *)buf++) > ^ ~~~~~ > 1 warning generated. > > It appears the intention was to cast the void pointer to a u16 pointer > so that the data could be iterated through like an array of u16 values. > However, the cast happens after the increment because a cast is an > rvalue, whereas the post-increment operator only works on lvalues, so > the loop does not iterate as expected. > > Replace the post-increment shorthand with the full expression so the > cast can be added in the right place and the look works as expected. > > Fixes: ac34df733d2d ("ALSA: usb-audio: scarlett2: Update get_config to do endian conversion") > Link: https://github.com/ClangBuiltLinux/linux/issues/1408 > Signed-off-by: Nathan Chancellor > --- > sound/usb/mixer_scarlett_gen2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c > index fcba682cd422..c20c7f1ddc50 100644 > --- a/sound/usb/mixer_scarlett_gen2.c > +++ b/sound/usb/mixer_scarlett_gen2.c > @@ -1186,7 +1186,7 @@ static int scarlett2_usb_get_config( > if (err < 0) > return err; > if (size == 2) > - for (i = 0; i < count; i++, (u16 *)buf++) > + for (i = 0; i < count; i++, buf = (u16 *)buf + 1) > *(u16 *)buf = le16_to_cpu(*(__le16 *)buf); That's still too error-prone. Could you rather introduce another variable of u16 * type, and use it instead? Ditto for u8 access for the code after that, too. thanks, Takashi