Re: [PATCH 5/8] sound: intel/sst: don't pass GFP_DMA32 to dma_alloc_coherent

[Takashi Iwai <tiwai@suse.de>]

[ Dropping other MLs ]

On Sat, 13 Oct 2018 18:20:35 +0200,
Takashi Iwai wrote:
> 
> On Sat, 13 Oct 2018 17:17:04 +0200,
> Christoph Hellwig wrote:
> > 
> > The DMA API does its own zone decisions based on the coherent_dma_mask.
> > 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Reviewed-by: Takashi Iwai <tiwai@suse.de>

Mark, let me know whether you'd take this via your tree or may I take
via mine (with a minor correction of the subject line).

FWIW, the driver sets the 31bit (!) DMA mask, and that's the likely
reason of GFP_DMA passed there in the original code.


thanks,

Takashi

> 
> 
> thanks,
> 
> Takashi
> 
> > ---
> >  sound/soc/intel/common/sst-firmware.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/sound/soc/intel/common/sst-firmware.c b/sound/soc/intel/common/sst-firmware.c
> > index 11041aedea31..1e067504b604 100644
> > --- a/sound/soc/intel/common/sst-firmware.c
> > +++ b/sound/soc/intel/common/sst-firmware.c
> > @@ -355,7 +355,7 @@ struct sst_fw *sst_fw_new(struct sst_dsp *dsp,
> >  
> >  	/* allocate DMA buffer to store FW data */
> >  	sst_fw->dma_buf = dma_alloc_coherent(dsp->dma_dev, sst_fw->size,
> > -				&sst_fw->dmable_fw_paddr, GFP_DMA | GFP_KERNEL);
> > +				&sst_fw->dmable_fw_paddr, GFP_KERNEL);
> >  	if (!sst_fw->dma_buf) {
> >  		dev_err(dsp->dev, "error: DMA alloc failed\n");
> >  		kfree(sst_fw);
> > -- 
> > 2.19.1
> > 
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> > 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>