Re: [Intel-gfx] [PATCH 1/3] drm/i915: Split audio component to a generic type

From: Takashi Iwai <tiwai@suse.de>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Jim Qu <Jim.Qu@amd.com>,
	alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Split audio component to a generic type
Date: Mon, 16 Jul 2018 19:50:48 +0200	[thread overview]
Message-ID: <s5hefg3kr2f.wl-tiwai@suse.de> (raw)
In-Reply-To: <20180716172216.GE4262@intel.com>

On Mon, 16 Jul 2018 19:22:17 +0200,
Rodrigo Vivi wrote:
> 
> > --- /dev/null
> > +++ b/include/drm/drm_audio_component.h
> > @@ -0,0 +1,115 @@
> > +/*
> > + * Copyright © 2014 Intel Corporation
> > + *
> > + * Permission is hereby granted, free of charge, to any person obtaining a
> > + * copy of this software and associated documentation files (the "Software"),
> > + * to deal in the Software without restriction, including without limitation
> > + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> > + * and/or sell copies of the Software, and to permit persons to whom the
> > + * Software is furnished to do so, subject to the following conditions:
> > + *
> > + * The above copyright notice and this permission notice (including the next
> > + * paragraph) shall be included in all copies or substantial portions of the
> > + * Software.
> > + *
> > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> > + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> > + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> > + * IN THE SOFTWARE.
> > + */
> 
> I think it is better to start new files with SPDX identifiers....

Yeah, it's a more sensible option.  Will rewrite in v2.

> > +
> > +#ifndef _DRM_AUDIO_COMPONENT_H_
> > +#define _DRM_AUDIO_COMPONENT_H_
> > +
> > +/**
> > + * struct drm_audio_component_ops - Ops implemented by DRM driver, called by hda driver
> > + */
> > +struct drm_audio_component_ops {
> > +	/**
> > +	 * @owner: i915 module
> 
> drm now?

Right.  Will be fixed in v2, too.

Thanks!

Takashi
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel