From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Audio crackles with 4.1-rc1 Date: Mon, 15 Jun 2015 14:04:30 +0200 Message-ID: References: <20150610194303.3b82609d@mdontu-l.dsd.bitdefender.biz> <20150611011236.53bcd1fd@mdontu-l> <20150612012318.6e3482ed@mdontu-l> <20150612124523.37fd0875@mdontu-l> <20150614122420.GT28070@earth.li> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 97336260695 for ; Mon, 15 Jun 2015 14:04:30 +0200 (CEST) In-Reply-To: <20150614122420.GT28070@earth.li> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Jonathan McDowell Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Mihai =?UTF-8?B?RG9uyJt1?= List-Id: alsa-devel@alsa-project.org QXQgU3VuLCAxNCBKdW4gMjAxNSAxMzoyNDoyMCArMDEwMCwKSm9uYXRoYW4gTWNEb3dlbGwgd3Jv dGU6Cj4gCj4gT24gRnJpLCBKdW4gMTIsIDIwMTUgYXQgMDQ6MTM6MTZQTSArMDIwMCwgVGFrYXNo aSBJd2FpIHdyb3RlOgo+ID4gQXQgRnJpLCAxMiBKdW4gMjAxNSAxMjowOTo1NSArMDIwMCwKPiA+ IFRha2FzaGkgSXdhaSB3cm90ZToKPiA+ID4gQXQgRnJpLCAxMiBKdW4gMjAxNSAxMjo0NToyMyAr MDMwMCwKPiA+ID4gTWloYWkgRG9uyJt1IHdyb3RlOgo+ID4gPiA+IE5pY2Ugc2hvdCEgSXQgYXBw ZWFycyB0byB3b3JrLiA6LSkgTm8gY2xpY2tzLCBubyBzdGF0aWMuCj4gPiA+IAo+ID4gPiBHb29k IHRvIGhlYXIhCj4gPiA+IAo+ID4gPiA+IEkgaGFkIHRvIGFwcGx5IGl0IGJ5IGhhbmQgb3ZlciA0 LjEtcmM3LCBiZWNhdXNlIHRoZSBmaXJzdCB0d28gYXJyYXlzCj4gPiA+ID4gbG9vayBkaWZmZXJl bnQgaW4gYm90aCBpdCBhbmQgLW1hc3Rlci4gQW55d2F5LCBJIHdpbGwgcGxheSB3aXRoIGl0IHNv bWUKPiA+ID4gPiBtb3JlIHRvZGF5IHNlZSBpZiBhbnl0aGluZyBlbHNlIGlzIGJyb2tlbi4KPiA+ ID4gCj4gPiA+IFdoaWxlIHdlIGFyZSBhdCBpdDogY291bGQgeW91IHRyeSB0byBlbmFibGUgY29k ZWMtPnBvd2VyX3NhdmVfbm9kZSBpbgo+ID4gPiBwYXRjaF9hbGMyNjkoKSAod2hpbGUga2VlcGlu ZyB0aGUgbmV3IHBhdGNoKT8KPiA+ID4gCj4gPiA+IC0tLSBhL3NvdW5kL3BjaS9oZGEvcGF0Y2hf cmVhbHRlay5jCj4gPiA+ICsrKyBiL3NvdW5kL3BjaS9oZGEvcGF0Y2hfcmVhbHRlay5jCj4gPiA+ IEBAIC01NjcxLDggKzU2NzEsNyBAQCBzdGF0aWMgaW50IHBhdGNoX2FsYzI2OShzdHJ1Y3QgaGRh X2NvZGVjICpjb2RlYykKPiA+ID4gIAo+ID4gPiAgCXNwZWMgPSBjb2RlYy0+c3BlYzsKPiA+ID4g IAlzcGVjLT5nZW4uc2hhcmVkX21pY192cmVmX3BpbiA9IDB4MTg7Cj4gPiA+IC0JaWYgKGNvZGVj LT5jb3JlLnZlbmRvcl9pZCAhPSAweDEwZWMwMjkyKQo+ID4gPiAtCQljb2RlYy0+cG93ZXJfc2F2 ZV9ub2RlID0gMTsKPiA+ID4gKwljb2RlYy0+cG93ZXJfc2F2ZV9ub2RlID0gMTsKPiA+ID4gIAo+ ID4gPiAgI2lmZGVmIENPTkZJR19QTQo+ID4gPiAgCWNvZGVjLT5wYXRjaF9vcHMuc3VzcGVuZCA9 IGFsYzI2OV9zdXNwZW5kOwo+ID4gCj4gPiBGb3IgeW91ciBjb252ZW5pZW5jZSwgYmVsb3cgaXMg dGhlIGNvbWJpbmVkIHBhdGNoIGZvciA0LjEuCj4gPiAKPiA+IEpvbmF0aGFuLCBjb3VsZCB5b3Ug YWxzbyB0cnkgdGhpcyBwYXRjaCBhbmQgc2VlIHdoZXRoZXIgeW91IHN0aWxsIGdldAo+ID4gdGhl IG5vaXNlPwo+IAo+IEFwcGx5aW5nIHRoZSBjb21iaW5lZCBwYXRjaCB0byA0LjEtcmM3IEknbSBu b3QgZ2V0dGluZyBhbnkgbm9pc2Ugb24gdGhlCj4gdHJhbnNpdGlvbiBmcm9tIHN1c3BlbmRlZCB0 byBhY3RpdmUuCgpHcmVhdCwgSSBxdWV1ZWQgdGhlIGZpeCBwYXRjaCBmb3IgNC4xLWZpbmFsIG5v dy4KCgp0aGFua3MsCgpUYWthc2hpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxzYS1wcm9q ZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8v YWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755325AbbFOMEj (ORCPT ); Mon, 15 Jun 2015 08:04:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:47555 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753930AbbFOMEb (ORCPT ); Mon, 15 Jun 2015 08:04:31 -0400 Date: Mon, 15 Jun 2015 14:04:30 +0200 Message-ID: From: Takashi Iwai To: Jonathan McDowell Cc: Mihai =?UTF-8?B?RG9uyJt1?= , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: Audio crackles with 4.1-rc1 In-Reply-To: <20150614122420.GT28070@earth.li> References: <20150610194303.3b82609d@mdontu-l.dsd.bitdefender.biz> <20150611011236.53bcd1fd@mdontu-l> <20150612012318.6e3482ed@mdontu-l> <20150612124523.37fd0875@mdontu-l> <20150614122420.GT28070@earth.li> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 14 Jun 2015 13:24:20 +0100, Jonathan McDowell wrote: > > On Fri, Jun 12, 2015 at 04:13:16PM +0200, Takashi Iwai wrote: > > At Fri, 12 Jun 2015 12:09:55 +0200, > > Takashi Iwai wrote: > > > At Fri, 12 Jun 2015 12:45:23 +0300, > > > Mihai Donțu wrote: > > > > Nice shot! It appears to work. :-) No clicks, no static. > > > > > > Good to hear! > > > > > > > I had to apply it by hand over 4.1-rc7, because the first two arrays > > > > look different in both it and -master. Anyway, I will play with it some > > > > more today see if anything else is broken. > > > > > > While we are at it: could you try to enable codec->power_save_node in > > > patch_alc269() (while keeping the new patch)? > > > > > > --- a/sound/pci/hda/patch_realtek.c > > > +++ b/sound/pci/hda/patch_realtek.c > > > @@ -5671,8 +5671,7 @@ static int patch_alc269(struct hda_codec *codec) > > > > > > spec = codec->spec; > > > spec->gen.shared_mic_vref_pin = 0x18; > > > - if (codec->core.vendor_id != 0x10ec0292) > > > - codec->power_save_node = 1; > > > + codec->power_save_node = 1; > > > > > > #ifdef CONFIG_PM > > > codec->patch_ops.suspend = alc269_suspend; > > > > For your convenience, below is the combined patch for 4.1. > > > > Jonathan, could you also try this patch and see whether you still get > > the noise? > > Applying the combined patch to 4.1-rc7 I'm not getting any noise on the > transition from suspended to active. Great, I queued the fix patch for 4.1-final now. thanks, Takashi