From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: Add missing __devexit_p() markers
Date: Thu, 04 Jun 2009 10:53:30 +0200
Message-ID: <s5heiu04bxx.wl%tiwai@suse.de>
References: <20090604104643.443fbe52@hyperion.delvare>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15])
	by alsa0.perex.cz (Postfix) with ESMTP id 13B7224453
	for <alsa-devel@alsa-project.org>;
	Thu,  4 Jun 2009 10:53:31 +0200 (CEST)
In-Reply-To: <20090604104643.443fbe52@hyperion.delvare>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Jean Delvare <khali@linux-fr.org>
Cc: Kyle McMartin <kyle@mcmartin.ca>, alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Thu, 4 Jun 2009 10:46:43 +0200,
Jean Delvare wrote:
> 
> 3 ISA sound drivers lack their __devexit_p() markers, which would
> cause build failures when the kernel is built without hotplug support.
> 
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Kyle McMartin <kyle@mcmartin.ca>
> Cc: Takashi Iwai <tiwai@suse.de>

Applied now.  Thanks!


Takashi

> ---
>  sound/isa/es1688/es1688.c  |    2 +-
>  sound/isa/gus/gusextreme.c |    2 +-
>  sound/parisc/harmony.c     |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> --- linux-2.6.30-rc8.orig/sound/isa/es1688/es1688.c	2009-04-08 08:54:02.000000000 +0200
> +++ linux-2.6.30-rc8/sound/isa/es1688/es1688.c	2009-06-04 10:37:06.000000000 +0200
> @@ -193,7 +193,7 @@ static int __devexit snd_es1688_remove(s
>  static struct isa_driver snd_es1688_driver = {
>  	.match		= snd_es1688_match,
>  	.probe		= snd_es1688_probe,
> -	.remove		= snd_es1688_remove,
> +	.remove		= __devexit_p(snd_es1688_remove),
>  #if 0	/* FIXME */
>  	.suspend	= snd_es1688_suspend,
>  	.resume		= snd_es1688_resume,
> --- linux-2.6.30-rc8.orig/sound/isa/gus/gusextreme.c	2009-04-08 08:54:02.000000000 +0200
> +++ linux-2.6.30-rc8/sound/isa/gus/gusextreme.c	2009-06-04 10:37:13.000000000 +0200
> @@ -348,7 +348,7 @@ static int __devexit snd_gusextreme_remo
>  static struct isa_driver snd_gusextreme_driver = {
>  	.match		= snd_gusextreme_match,
>  	.probe		= snd_gusextreme_probe,
> -	.remove		= snd_gusextreme_remove,
> +	.remove		= __devexit_p(snd_gusextreme_remove),
>  #if 0	/* FIXME */
>  	.suspend	= snd_gusextreme_suspend,
>  	.resume		= snd_gusextreme_resume,
> --- linux-2.6.30-rc8.orig/sound/parisc/harmony.c	2009-04-08 08:54:03.000000000 +0200
> +++ linux-2.6.30-rc8/sound/parisc/harmony.c	2009-06-04 10:37:25.000000000 +0200
> @@ -1020,7 +1020,7 @@ static struct parisc_driver snd_harmony_
>  	.name = "harmony",
>  	.id_table = snd_harmony_devtable,
>  	.probe = snd_harmony_probe,
> -	.remove = snd_harmony_remove,
> +	.remove = __devexit_p(snd_harmony_remove),
>  };
>  
>  static int __init 
> 
> 
> -- 
> Jean Delvare
>