From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 2/2] ac97: YMF743 missing controls support
Date: Wed, 19 Sep 2007 13:06:38 +0200
Message-ID: <s5hejgusym9.wl%tiwai@suse.de>
References: <87r6kwotup.wl%maehara@debian.org> <s5hvea8rmdp.wl%tiwai@suse.de>
	<87abrj1qpg.wl%maehara@debian.org>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx1.suse.de (ns.suse.de [195.135.220.2])
	by alsa0.perex.cz (Postfix) with ESMTP id C6FA110380E
	for <alsa-devel@alsa-project.org>;
	Wed, 19 Sep 2007 13:06:38 +0200 (CEST)
In-Reply-To: <87abrj1qpg.wl%maehara@debian.org>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Sender: alsa-devel-bounces@alsa-project.org
Errors-To: alsa-devel-bounces@alsa-project.org
To: Keita Maehara <maehara@debian.org>
Cc: alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

At Wed, 19 Sep 2007 08:47:23 +0900,
Keita Maehara wrote:
> 
> At Tue, 18 Sep 2007 18:04:02 +0200,
> Takashi Iwai wrote:
> 
> > At Wed, 19 Sep 2007 00:50:54 +0900,
> > Keita Maehara wrote:
> > > 
> > > From: Keita Maehara <maehara@debian.org>
> > > 
> > > These patches enable a few YMF743 controls (Tone/3D/IEC958) that won't
> > > be detected with the current version of ALSA.
> > > 
> > > Signed-off-by: Keita Maehara <maehara@debian.org>
> > 
> > The changes look good to me, but I'd like to ask you to rewrite the
> > patch to follow the standard coding style.  Yes, the original ac97
> > code doesn't follow, but at least, we should do it right for the newly
> > added/changed codes.  For example, keep lines within 80 chars, fold
> > lines appropriately, avoid if ((err = ...)) style, etc.
> 
> I was wondering whether to follow the coding style for them indeed but
> understood the policy now. Sorry to bother you.
> 
> > In doubt, you can run scripts/checkpatch.pl in the linux kernel tree.
> 
> Now they're checkpatch-clean anyway. I've put the second version at
> http://people.debian.org/~maehara/alsa-ymf743.

Could you repost here again?  Then I could give further review
comments (if any).


thanks,

Takashi