From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: re.Fix hang in mpu401_uart.c patch Date: Thu, 11 May 2006 16:07:25 +0200 Message-ID: References: <200605101556.50928.gineera@aspect135.co.uk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <200605101556.50928.gineera@aspect135.co.uk> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Alan Horstmann Cc: alsa-devel@lists.sourceforge.net List-Id: alsa-devel@alsa-project.org At Wed, 10 May 2006 16:10:41 +0100, Alan Horstmann wrote: > > This patch since 1.0.11 throws up an underlying problem with au88x0 (separate > posting refers), but I also noticed that the 4th hunk applys changes to > snd_mpu401_uart_input_close and snd_mpu401_uart_output_close. > > However, as the 3rd augument is '0' ie don't check ACK, OK is always true in > snd_mpu401_uart_cmd and there is surely no point to the extra check lines? > > (As my separate posting 'au88x0_mpu401 init / fail first open' mentions, ACK > is not returned from the RESET during the close, either with ice1712 or > au8820, so can't be checked for.) Which patch are you referring to?? Takashi ------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642