All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Alan Cox <alan@redhat.com>
Cc: perex@suse.cz, akpm@osdl.org, linux-kernel@vger.kernel.org,
	trivial@rustcorp.com.au
Subject: Re: PATCH: Dell laptop lockup fix for ALSA
Date: Mon, 21 Jun 2004 16:24:39 +0200	[thread overview]
Message-ID: <s5heko9m1js.wl@alsa2.suse.de> (raw)
In-Reply-To: <20040621121647.GA16714@devserv.devel.redhat.com>

At Mon, 21 Jun 2004 08:16:47 -0400,
Alan Cox wrote:
> 
> OSS avoids the Dell lockup by not hitting the problem register (which 
> apparently breaks resume on a Sony laptop). ALSA keeps a flag and uses
> pci subvendor info to clear it for problem Dell laptops. Unfortunately
> there is at least one other Dell laptop which is affected. This adds
> its sub id's

Could you fix the comment, too?  Surely it's no Sony laptop ;)


--
Takashi Iwai <tiwai@suse.de>		ALSA Developer - www.alsa-project.org


> 
> [Patch from Dan Williams @ Red Hat slightly reformatted by me]
> 
> 
> --- sound/pci/nm256/nm256.c	2004-06-14 14:11:34.000000000 +0100
> +++ /tmp/nm256.c	2004-06-21 12:08:49.099484448 +0100
> @@ -1509,6 +1509,10 @@
>  		/* this workaround will cause lock-up after suspend/resume on Sony PCG-F305 */
>  		chip->latitude_workaround = 0;
>  	}
> +	if (subsystem_vendor == 0x1028 && subsystem_device == 0x0080) {
> +		/* this workaround will cause lock-up after suspend/resume on Sony PCG-F305 */
> +		chip->latitude_workaround = 0;
> +	}
>  
>  	snd_nm256_init_chip(chip);
>  
> 
> 
> 
>       Developer's Certificate of Origin 1.0
>  
>         By making a contribution to this project, I certify that:
>  
>         (a) The contribution was created in whole or in part by me and I
>             have the right to submit it under the open source license
>             indicated in the file; or
>  
>         (b) The contribution is based upon previous work that, to the best
>             of my knowledge, is covered under an appropriate open source
>             license and I have the right under that license to submit that
>             work with modifications, whether created in whole or in part
>             by me, under the same open source license (unless I am
>             permitted to submit under a different license), as indicated
>             in the file; or
>  
>         (c) The contribution was provided directly to me by some other
>             person who certified (a), (b) or (c) and I have not modified
>             it.
> 
> 
> Signed-off-by: Alan Cox <alan@redhat.com>
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

      reply	other threads:[~2004-06-21 14:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-21 12:16 PATCH: Dell laptop lockup fix for ALSA Alan Cox
2004-06-21 14:24 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5heko9m1js.wl@alsa2.suse.de \
    --to=tiwai@suse.de \
    --cc=akpm@osdl.org \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@suse.cz \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.