From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 452AAC433E0 for ; Thu, 4 Feb 2021 07:04:55 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C01064D9E for ; Thu, 4 Feb 2021 07:04:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C01064D9E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 128D41709; Thu, 4 Feb 2021 08:04:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 128D41709 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1612422292; bh=BdzpNIH+ss4vxkEiKpXdXEPrV1mIcTn7xQom7lnvv7g=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=RapRhOLkjWuEvGOI0zczQRqhgxgZq1H4MaSR1+gHC3uV64ZCubO40kShJAByn04el D8w1+7udgmhvLZMlnPqfTrjUrAVAmD2HWW+OrNIWD/3tQ9uiMlCmjWLuPNaY6sZK+4 gqS09qbS8rhtNIi/D4DjG3muwhzwVbw21j+ZnNK0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8443EF80171; Thu, 4 Feb 2021 08:04:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 80232F80171; Thu, 4 Feb 2021 08:04:00 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 62905F80155 for ; Thu, 4 Feb 2021 08:03:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 62905F80155 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 37A2AAC97; Thu, 4 Feb 2021 07:03:53 +0000 (UTC) Date: Thu, 04 Feb 2021 08:03:53 +0100 Message-ID: From: Takashi Iwai To: Olivia Mackintosh Subject: Re: [PATCH v2 0/2] Add DJM-750 and simplify In-Reply-To: <20210204034432.15504-1-livvy@base.nu> References: <20210128160338.dac4vrj7wjiykcxm@base.nu> <20210204034432.15504-1-livvy@base.nu> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Fabian Lesniak X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 04 Feb 2021 04:44:30 +0100, Olivia Mackintosh wrote: > > This is a re-roll of my last patch with the addition of some > improvements. Hopefully it reduces the noise a little and simplifies the > adding of new devices. One thing I haven't done here is replace the > arrays of values for each channel with a named definition. In order to > do this, the actual wValue would need to include the channel mask. > > Olivia Mackintosh (2): > ALSA: usb-audio: Add DJM750 to Pioneer mixer quirk > ALSA: usb-audio: Simplify DJM mixer quirks checkpatch.pl complains a few things in both patches. While many of warnings can be ignored, some errors (e.g. the brace should be put in the next line for the function definition) need to be addressed. Could you fix and resubmit? thanks, Takashi