From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50F52C4363A for ; Tue, 27 Oct 2020 08:16:39 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68ED720878 for ; Tue, 27 Oct 2020 08:16:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="gawLSP7m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68ED720878 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id DBD0E169C; Tue, 27 Oct 2020 09:15:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz DBD0E169C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1603786595; bh=C0QSlASXPQSFtJCRfdYqR1MjyhSK0hXspQNSSWpO9+8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gawLSP7mVEWgyq9KDcAoq6/G+UT/33GX8M7NNyXxa6TA9VyVEkeaAbjafrBHZnrd0 5snUA8FnMrc0HhtwhVBYgXfNmqZWc1uC0eA3aJie6jRJ2daKI5nwbjQsv1Otrrtd7u ChatDwl9KhHuSETZ3P7Rfy7U1iyaUtRjcvLv/OBI= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4920EF801D8; Tue, 27 Oct 2020 09:15:44 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 58151F8020D; Tue, 27 Oct 2020 09:15:42 +0100 (CET) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E0007F800FF for ; Tue, 27 Oct 2020 09:15:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E0007F800FF X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 99C0FAC2F; Tue, 27 Oct 2020 08:15:39 +0000 (UTC) Date: Tue, 27 Oct 2020 09:15:39 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Subject: Re: [PATCH v2 3/4] ALSA: hda: Separate runtime and system suspend In-Reply-To: References: <20201027054001.1800-1-kai.heng.feng@canonical.com> <20201027054001.1800-4-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, kai.vehmanen@linux.intel.com, linux-kernel@vger.kernel.org, tiwai@suse.com, hui.wang@canonical.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 27 Oct 2020 09:12:07 +0100, Takashi Iwai wrote: > > On Tue, 27 Oct 2020 08:46:05 +0100, > Takashi Iwai wrote: > > > @@ -1103,10 +1115,8 @@ static int azx_runtime_suspend(struct device *dev) > > > chip = card->private_data; > > > > > > /* enable controller wake up event */ > > > - if (snd_power_get_state(card) == SNDRV_CTL_POWER_D0) { > > > - azx_writew(chip, WAKEEN, azx_readw(chip, WAKEEN) | > > > - STATESTS_INT_MASK); > > > - } > > > + azx_writew(chip, WAKEEN, azx_readw(chip, WAKEEN) | > > > + STATESTS_INT_MASK); > > > > ... here we should have the check of chip->prepared, and set WAKEEN > > only when it's false. Otherwise WAKEEN is set up for the system > > suspend, and it might lead to spurious wakeups. (IOW, checking the > > flag at resume doesn't help for preventing the spurious wakeup :) > > Scratch my comment above; it's the code path only for the runtime > suspend in your new code, then this cleanup makes sense. Also, as one more cleanup: from_rt in __azx_runtime_resume() can be replaced with !chip->prepared flag, so the extra argument can be dropped. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25035C4363A for ; Tue, 27 Oct 2020 08:15:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B992C21D24 for ; Tue, 27 Oct 2020 08:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2894501AbgJ0IPl (ORCPT ); Tue, 27 Oct 2020 04:15:41 -0400 Received: from mx2.suse.de ([195.135.220.15]:45924 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2509021AbgJ0IPk (ORCPT ); Tue, 27 Oct 2020 04:15:40 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 99C0FAC2F; Tue, 27 Oct 2020 08:15:39 +0000 (UTC) Date: Tue, 27 Oct 2020 09:15:39 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: tiwai@suse.com, perex@perex.cz, hui.wang@canonical.com, kai.vehmanen@linux.intel.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] ALSA: hda: Separate runtime and system suspend In-Reply-To: References: <20201027054001.1800-1-kai.heng.feng@canonical.com> <20201027054001.1800-4-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Oct 2020 09:12:07 +0100, Takashi Iwai wrote: > > On Tue, 27 Oct 2020 08:46:05 +0100, > Takashi Iwai wrote: > > > @@ -1103,10 +1115,8 @@ static int azx_runtime_suspend(struct device *dev) > > > chip = card->private_data; > > > > > > /* enable controller wake up event */ > > > - if (snd_power_get_state(card) == SNDRV_CTL_POWER_D0) { > > > - azx_writew(chip, WAKEEN, azx_readw(chip, WAKEEN) | > > > - STATESTS_INT_MASK); > > > - } > > > + azx_writew(chip, WAKEEN, azx_readw(chip, WAKEEN) | > > > + STATESTS_INT_MASK); > > > > ... here we should have the check of chip->prepared, and set WAKEEN > > only when it's false. Otherwise WAKEEN is set up for the system > > suspend, and it might lead to spurious wakeups. (IOW, checking the > > flag at resume doesn't help for preventing the spurious wakeup :) > > Scratch my comment above; it's the code path only for the runtime > suspend in your new code, then this cleanup makes sense. Also, as one more cleanup: from_rt in __azx_runtime_resume() can be replaced with !chip->prepared flag, so the extra argument can be dropped. Takashi