From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH 18/21] ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD Date: Tue, 29 Oct 2019 06:49:08 +0100 Message-ID: References: <20191028214216.1508370-1-alexander.deucher@amd.com> <20191028214216.1508370-19-alexander.deucher@amd.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191028214216.1508370-19-alexander.deucher-5C7GfCeVMHo@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Alex Deucher Cc: Alex Deucher , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org, Evan Quan , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T24gTW9uLCAyOCBPY3QgMjAxOSAyMjo0MjoxMyArMDEwMCwKQWxleCBEZXVjaGVyIHdyb3RlOgo+ IAo+IEBAIC0zNSw2ICszNSwxMSBAQAo+ICAjaW5jbHVkZSA8bGludXgvY2xvY2tzb3VyY2UuaD4K PiAgI2luY2x1ZGUgPGxpbnV4L3RpbWUuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2NvbXBsZXRpb24u aD4KPiArI2lmZGVmIFNVUFBPUlRfVkdBX1NXSVRDSEVST08KPiArI2lmZGVmIENPTkZJR19BQ1BJ Cj4gKyNpbmNsdWRlIDxsaW51eC9hY3BpLmg+Cj4gKyNlbmRpZgo+ICsjZW5kaWYKCkkgZG9uJ3Qg dGhpbmsgd2UgbmVlZCBpZmRlZnMgaGVyZS4KT3RoZXIgdGhhbiB0aGF0LAogIFJldmlld2VkLWJ5 OiBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuZGU+CgoKdGhhbmtzLAoKVGFrYXNoaQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcg bGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9699CA9EB9 for ; Tue, 29 Oct 2019 05:49:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D9AC20659 for ; Tue, 29 Oct 2019 05:49:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D9AC20659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E0ED6E07D; Tue, 29 Oct 2019 05:49:13 +0000 (UTC) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id DC8846E07D for ; Tue, 29 Oct 2019 05:49:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1FC7FB178; Tue, 29 Oct 2019 05:49:09 +0000 (UTC) Date: Tue, 29 Oct 2019 06:49:08 +0100 Message-ID: From: Takashi Iwai To: Alex Deucher Subject: Re: [PATCH 18/21] ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD In-Reply-To: <20191028214216.1508370-19-alexander.deucher@amd.com> References: <20191028214216.1508370-1-alexander.deucher@amd.com> <20191028214216.1508370-19-alexander.deucher@amd.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alex Deucher , alsa-devel@alsa-project.org, lukas@wunner.de, Evan Quan , amd-gfx@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Message-ID: <20191029054908.-XTBPT46cVm7s6z5HN2RTE2wKb_qxHdd-KTc2IfHz_k@z> T24gTW9uLCAyOCBPY3QgMjAxOSAyMjo0MjoxMyArMDEwMCwKQWxleCBEZXVjaGVyIHdyb3RlOgo+ IAo+IEBAIC0zNSw2ICszNSwxMSBAQAo+ICAjaW5jbHVkZSA8bGludXgvY2xvY2tzb3VyY2UuaD4K PiAgI2luY2x1ZGUgPGxpbnV4L3RpbWUuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2NvbXBsZXRpb24u aD4KPiArI2lmZGVmIFNVUFBPUlRfVkdBX1NXSVRDSEVST08KPiArI2lmZGVmIENPTkZJR19BQ1BJ Cj4gKyNpbmNsdWRlIDxsaW51eC9hY3BpLmg+Cj4gKyNlbmRpZgo+ICsjZW5kaWYKCkkgZG9uJ3Qg dGhpbmsgd2UgbmVlZCBpZmRlZnMgaGVyZS4KT3RoZXIgdGhhbiB0aGF0LAogIFJldmlld2VkLWJ5 OiBUYWthc2hpIEl3YWkgPHRpd2FpQHN1c2UuZGU+CgoKdGhhbmtzLAoKVGFrYXNoaQpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcg bGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DB47CA9EB9 for ; Tue, 29 Oct 2019 05:50:09 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BB9920862 for ; Tue, 29 Oct 2019 05:50:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="mElJf3oJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BB9920862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4614421AD; Tue, 29 Oct 2019 06:49:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4614421AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572328206; bh=vxLwlyG9e8tbOBwlRKe00gKQHC9d17jz/cjtNRzZBdQ=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mElJf3oJdoi3bHvwhbBQKhlhLqKEAwOZ6g63z/QSeqNp7uYWtxp2PDe7/1qzqhpZt iXb0cuIZmFZVauaVTD2tVPFQmNmfka2LLOLnxlNWHBoHE7KdGh+nwvPdBCV5j1s8ni S8iLsd07IzWj5zpDDh00d+3C8M1Rysq6w6iM1pEg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 95D63F8036C; Tue, 29 Oct 2019 06:49:15 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 64566F80392; Tue, 29 Oct 2019 06:49:13 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 99EE7F800E7 for ; Tue, 29 Oct 2019 06:49:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 99EE7F800E7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1FC7FB178; Tue, 29 Oct 2019 05:49:09 +0000 (UTC) Date: Tue, 29 Oct 2019 06:49:08 +0100 Message-ID: From: Takashi Iwai To: Alex Deucher In-Reply-To: <20191028214216.1508370-19-alexander.deucher@amd.com> References: <20191028214216.1508370-1-alexander.deucher@amd.com> <20191028214216.1508370-19-alexander.deucher@amd.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: Alex Deucher , alsa-devel@alsa-project.org, lukas@wunner.de, Evan Quan , amd-gfx@lists.freedesktop.org Subject: Re: [alsa-devel] [PATCH 18/21] ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 28 Oct 2019 22:42:13 +0100, Alex Deucher wrote: > > @@ -35,6 +35,11 @@ > #include > #include > #include > +#ifdef SUPPORT_VGA_SWITCHEROO > +#ifdef CONFIG_ACPI > +#include > +#endif > +#endif I don't think we need ifdefs here. Other than that, Reviewed-by: Takashi Iwai thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel