From: Takashi Iwai <tiwai@suse.de>
To: mengdong.lin@linux.intel.com
Cc: vinod.koul@intel.com, mengdong.lin@intel.com,
alsa-devel@alsa-project.org, subhransu.s.prusty@intel.com,
liam.r.girdwood@intel.com
Subject: Re: [PATCH 3/4] topology: Remove unused variables
Date: Wed, 18 Nov 2015 14:58:49 +0100 [thread overview]
Message-ID: <s5hfv03e7dy.wl-tiwai@suse.de> (raw)
In-Reply-To: <c5ce2ce885b6fa68391a9e66c6b675beb2ce5a43.1447825540.git.mengdong.lin@linux.intel.com>
On Wed, 18 Nov 2015 08:23:19 +0100,
mengdong.lin@linux.intel.com wrote:
>
> From: Mengdong Lin <mengdong.lin@linux.intel.com>
>
> Fix gcc warning when -Wunused-variable is set.
>
> Signed-off-by: Mengdong Lin <mengdong.lin@linux.intel.com>
Thanks, applied.
Takashi
>
> diff --git a/src/topology/pcm.c b/src/topology/pcm.c
> index 4b7c058..d90a9ea 100644
> --- a/src/topology/pcm.c
> +++ b/src/topology/pcm.c
> @@ -58,7 +58,6 @@ static int tplg_build_pcm_caps(snd_tplg_t *tplg, struct tplg_elem *elem)
> struct tplg_elem *ref_elem = NULL;
> struct snd_soc_tplg_pcm *pcm;
> struct snd_soc_tplg_stream_caps *caps;
> - struct snd_soc_tplg_stream *stream;
> unsigned int i;
>
> pcm = elem->pcm;
> @@ -273,7 +272,7 @@ int tplg_parse_stream_caps(snd_tplg_t *tplg, snd_config_t *cfg,
> struct tplg_elem *elem = private;
> struct snd_soc_tplg_pcm *pcm;
> const char *id, *value;
> - int err, stream;
> + int stream;
>
> pcm = elem->pcm;
>
> @@ -384,7 +383,6 @@ int tplg_parse_be(snd_tplg_t *tplg,
> snd_config_iterator_t i, next;
> snd_config_t *n;
> const char *id, *val = NULL;
> - int err;
>
> elem = tplg_elem_new_common(tplg, cfg, NULL, SND_TPLG_TYPE_BE);
> if (!elem)
> @@ -438,7 +436,6 @@ int tplg_parse_cc(snd_tplg_t *tplg,
> snd_config_iterator_t i, next;
> snd_config_t *n;
> const char *id, *val = NULL;
> - int err;
>
> elem = tplg_elem_new_common(tplg, cfg, NULL, SND_TPLG_TYPE_CC);
> if (!elem)
> --
> 2.5.0
>
next prev parent reply other threads:[~2015-11-18 13:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 7:21 [PATCH 0/4] topology: fix some gcc warnings mengdong.lin
2015-11-18 7:22 ` [PATCH 1/4] topology: Remove unused function write_data_block() mengdong.lin
2015-11-18 13:58 ` Takashi Iwai
2015-11-18 7:23 ` [PATCH 2/4] topology: Change variable type to fix gcc warning mengdong.lin
2015-11-18 7:15 ` Takashi Iwai
2015-11-18 7:28 ` Lin, Mengdong
2015-11-18 8:19 ` Takashi Iwai
2015-11-18 15:14 ` Lin, Mengdong
2015-11-18 15:26 ` Takashi Iwai
2015-11-18 7:23 ` [PATCH 3/4] topology: Remove unused variables mengdong.lin
2015-11-18 13:58 ` Takashi Iwai [this message]
2015-11-18 7:23 ` [PATCH 4/4] topology: Fix comparison of unsigned expression < 0 mengdong.lin
2015-11-18 13:59 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hfv03e7dy.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@intel.com \
--cc=mengdong.lin@intel.com \
--cc=mengdong.lin@linux.intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.