All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	mail@maciej.szmigiero.name, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: ac97: ac97_patch: Simplify patch_vt1613_specific()
Date: Fri, 06 Mar 2015 17:47:38 +0100	[thread overview]
Message-ID: <s5hfv9i2hud.wl-tiwai@suse.de> (raw)
In-Reply-To: <1425660102-5419-1-git-send-email-festevam@gmail.com>

At Fri,  6 Mar 2015 13:41:42 -0300,
Fabio Estevam wrote:
> 
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> We can simplify the code by returning patch_build_controls() directly.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Thanks, applied.


Takashi

> ---
>  sound/pci/ac97/ac97_patch.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/sound/pci/ac97/ac97_patch.c b/sound/pci/ac97/ac97_patch.c
> index eca2210..f4234ed 100644
> --- a/sound/pci/ac97/ac97_patch.c
> +++ b/sound/pci/ac97/ac97_patch.c
> @@ -3360,14 +3360,8 @@ AC97_SINGLE("DC Offset removal", 0x5a, 10, 1, 0),
>  
>  static int patch_vt1613_specific(struct snd_ac97 *ac97)
>  {
> -	int err;
> -
> -	err = patch_build_controls(ac97, &snd_ac97_controls_vt1613[0],
> -				ARRAY_SIZE(snd_ac97_controls_vt1613));
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return patch_build_controls(ac97, &snd_ac97_controls_vt1613[0],
> +				    ARRAY_SIZE(snd_ac97_controls_vt1613));
>  };
>  
>  static const struct snd_ac97_build_ops patch_vt1613_ops = {
> -- 
> 1.9.1
> 

      reply	other threads:[~2015-03-06 16:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06 16:41 [PATCH] ALSA: ac97: ac97_patch: Simplify patch_vt1613_specific() Fabio Estevam
2015-03-06 16:47 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hfv9i2hud.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=mail@maciej.szmigiero.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.