Re: [patch] for 9880 spdif out

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 869 bytes --]

At Thu, 17 Mar 2005 12:41:24 +0100,
I wrote:
> 
> > --- alsa-kernel/pci/hda/hda_codec.c	16 Mar 2005 13:37:09 -0000	1.7
> > +++ alsa-kernel/pci/hda/hda_codec.c	17 Mar 2005 04:40:12 -0000
> > @@ -955,6 +955,8 @@
> >  	if (change || codec->in_resume) {
> >  		codec->spdif_ctls = val;
> >  		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1, val & 0xff);
> > +		put_vol_mute(codec, nid, 0, HDA_OUTPUT, 0, val ? 0 : 0x80);
> > +		put_vol_mute(codec, nid, 1, HDA_OUTPUT, 0, val ? 0 : 0x80);
> 
> It should check only the enable bit (bit0) of val.
> Also, these two calls can be a single verb, e.g.
> 
> 	snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_AMP_GAIN_MUTE,
> 			AC_AMP_SET_LEFT|AC_AMP_SET_RIGHT|AC_AMP_SET_OUTPUT|
> 			((val & 1) ? 0 : 0x80));
> 
> Could you check whether this works?

OK the patch is below.  Please let me know if it works.


Takashi

[-- Attachment #2: Type: text/plain, Size: 727 bytes --]

Index: alsa-kernel/pci/hda/hda_codec.c
===================================================================
RCS file: /home/iwai/cvs/alsa/alsa-kernel/pci/hda/hda_codec.c,v
retrieving revision 1.8
diff -u -r1.8 hda_codec.c
--- alsa-kernel/pci/hda/hda_codec.c	16 Mar 2005 13:36:04 -0000	1.8
+++ alsa-kernel/pci/hda/hda_codec.c	18 Mar 2005 13:45:34 -0000
@@ -955,6 +955,9 @@
 	if (change || codec->in_resume) {
 		codec->spdif_ctls = val;
 		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_DIGI_CONVERT_1, val & 0xff);
+		snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_AMP_GAIN_MUTE,
+				    AC_AMP_SET_RIGHT | AC_AMP_SET_LEFT |
+				    AC_AMP_SET_OUTPUT | ((val & 1) ? 0 : 0x80));
 	}
 	up(&codec->spdif_mutex);
 	return change;