Re: [Fwd: Re: Linux 2.6.10-ac8] - Patch breaks audio report

[Takashi Iwai <tiwai@suse.de>]

At Thu, 13 Jan 2005 17:02:34 +0000,
Alan Cox wrote:
> 
> On Iau, 2005-01-13 at 17:10, Takashi Iwai wrote:
> > He just needs to turn off "Headphone Jack Sense" mixer switch.  That
> > resets the bit which was turned on by the patch.
> > 
> > The bit was set since most of machines with this codec are laptops and
> > need this feature.
> 
> 
> Are you sure - I've been _deluged_ by complaints about audio breakage
> from this change ?

Hmm, I didn't know this hits so many people.  At least, didn't get
complains on ALSA bugtracks.

The patch adds basically two controls to turn on/off bits 9 and 11 of
a JACK_SPDIF register on AD1981A/B.  The only influenceable change is
that the bit 11 is turned on as default.  Turning off via the control
must restore the same register state as previous version.

Maybe, it'd be safer not to touch this bit except for certain
machines?  The additional patch is attached below.


Takashi

================================================================

Summary: [ALSA] Don't touch the HP sense bit as default

Disable the toggle of HP sense bit at the initialization since this
looks hitting many people.

Signed-off-by: Takashi Iwai <tiwai@suse.de>


--- linux/sound/pci/ac97/ac97_patch.c	11 Jan 2005 15:28:11 -0000	1.69
+++ linux/sound/pci/ac97/ac97_patch.c	13 Jan 2005 18:17:12 -0000
@@ -1113,7 +1113,9 @@
 	ac97->build_ops = &patch_ad1981a_build_ops;
 	snd_ac97_update_bits(ac97, AC97_AD_MISC, AC97_AD198X_MSPLT, AC97_AD198X_MSPLT);
 	ac97->flags |= AC97_STEREO_MUTES;
+#if 0
 	snd_ac97_update_bits(ac97, AC97_AD_JACK_SPDIF, 1<<11, 1<<11); /* HP jack sense */
+#endif
 	return 0;
 }
 
@@ -1144,7 +1146,9 @@
 	ac97->build_ops = &patch_ad1981b_build_ops;
 	snd_ac97_update_bits(ac97, AC97_AD_MISC, AC97_AD198X_MSPLT, AC97_AD198X_MSPLT);
 	ac97->flags |= AC97_STEREO_MUTES;
+#if 0
 	snd_ac97_update_bits(ac97, AC97_AD_JACK_SPDIF, 1<<11, 1<<11); /* HP jack sense */
+#endif
 	return 0;
 }
 


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt