Re: EMU10K1 patch loader

[Takashi Iwai <tiwai@suse.de>]

Hi,

At Mon, 16 Jun 2003 09:38:39 +0200,
p z oooo wrote:
> 
> You can downoad it from http://pzwz.wz.cz
> No TRAM support yet (I am working on it).

wow, it looks great!  i'm just compiling and looking at the code.
(sorry for the late response, i've overlooked the post after my
vacation.)

a very subtle thing i found is that the hack of snd_ctl_elem_id_t.
it must be a bug of alsa-driver's part.  the struct should be
rewritten with the clear definition using the normal variable types,
because it's exported to the non-kernel purpose.

i.e. instead of

	snd_ctl_elem_id_t id;		/* full control ID definition */

we define the exactly same struct as the emu10k1 private data in
emu10k1.h, such as

	struct emu10k1_fx8010_id {
		unsigned int numid;		/* numeric identifier, zero = invalid */
		enum sndrv_ctl_elem_iface iface; /* interface identifier */
		unsigned int device;		/* device/client number */
		unsigned int subdevice;		/* subdevice (substream) number */
	        unsigned char name[44];		/* ASCII name of item */
		unsigned int index;		/* index of item */
	};

so that you'll need only emu10k1.h for inclusion.  no sound/asound.h.


btw, this would be worthy definitely to be included in the standard
alsa-tools.  please let me know if the code is ready for inclusion.


ciao,

Takashi


-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01