[PATCH] let 2.5.51 build

[PATCH] let 2.5.51 build

[Thierry Vignaud]

[-- Attachment #1: Type: text/plain, Size: 69 bytes --]

this patch enable 2.5.51 kernel to build without sequencer support :

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: alsa-fix-compile.diff --]
[-- Type: text/x-patch, Size: 421 bytes --]

fix compiling without sequencer support
--- ./sound/synth/Makefile.tv	2002-12-10 22:02:00.000000000 -0500
+++ ./sound/synth/Makefile	2002-12-10 21:50:37.000000000 -0500
@@ -12,8 +12,8 @@
 obj-$(CONFIG_SND_TRIDENT) += snd-util-mem.o
 ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
   obj-$(CONFIG_SND_SBAWE) += snd-util-mem.o
+obj-$(CONFIG_SND) += emux/
 endif
 
-obj-$(CONFIG_SND) += emux/
 
 include $(TOPDIR)/Rules.make

Re: [PATCH] let 2.5.51 build

[Takashi Iwai]

At Wed, 11 Dec 2002 10:51:05 +0100,
Thierry Vignaud wrote:
> 
> [1  <text/plain (7bit)>]
> this patch enable 2.5.51 kernel to build without sequencer support :

hmm, applying this is surely harmless but i still don't figure out
why this fixes the bug.  synth/emux/Makefile is:

snd-emux-synth-objs := emux.o emux_synth.o emux_seq.o emux_nrpn.o \
		       emux_effect.o emux_proc.o soundfont.o
ifeq ($(CONFIG_SND_SEQUENCER_OSS),y)
  snd-emux-synth-objs += emux_oss.o
endif

# Toplevel Module Dependency
ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
  obj-$(CONFIG_SND_SBAWE) += snd-emux-synth.o
  obj-$(CONFIG_SND_EMU10K1) += snd-emux-synth.o
endif

and if $CONFIG_SND_SEQUENCER is n, snd-emux-synth.o will be never
compiled nor built-in...


Takashi

> [2 alsa-fix-compile.diff <text/x-patch (7bit)>]
> fix compiling without sequencer support
> --- ./sound/synth/Makefile.tv	2002-12-10 22:02:00.000000000 -0500
> +++ ./sound/synth/Makefile	2002-12-10 21:50:37.000000000 -0500
> @@ -12,8 +12,8 @@
>  obj-$(CONFIG_SND_TRIDENT) += snd-util-mem.o
>  ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
>    obj-$(CONFIG_SND_SBAWE) += snd-util-mem.o
> +obj-$(CONFIG_SND) += emux/
>  endif
>  
> -obj-$(CONFIG_SND) += emux/
>  
>  include $(TOPDIR)/Rules.make


-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility 
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/

Re: [PATCH] let 2.5.51 build

[Thierry Vignaud]

Takashi Iwai <tiwai@suse.de> writes:

> > this patch enable 2.5.51 kernel to build without sequencer support :
> 
> hmm, applying this is surely harmless but i still don't figure out
> why this fixes the bug.  synth/emux/Makefile is:
> 
> snd-emux-synth-objs := emux.o emux_synth.o emux_seq.o emux_nrpn.o \
> 		       emux_effect.o emux_proc.o soundfont.o
> ifeq ($(CONFIG_SND_SEQUENCER_OSS),y)
>   snd-emux-synth-objs += emux_oss.o
> endif
> 
> # Toplevel Module Dependency
> ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
>   obj-$(CONFIG_SND_SBAWE) += snd-emux-synth.o
>   obj-$(CONFIG_SND_EMU10K1) += snd-emux-synth.o
> endif
> 
> and if $CONFIG_SND_SEQUENCER is n, snd-emux-synth.o will be never
> compiled nor built-in...

hummmm. must be some sort of "too late in the night to compile a
kernel" workaround for a broken make rule (was not able to build
emux/built-in.o if i remember right)

so you can just discard this patch



-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility 
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/

Re: [PATCH] let 2.5.51 build

[Takashi Iwai]

At Wed, 11 Dec 2002 16:51:23 +0100,
Thierry Vignaud wrote:
> 
> Takashi Iwai <tiwai@suse.de> writes:
> 
> > > this patch enable 2.5.51 kernel to build without sequencer support :
> > 
> > hmm, applying this is surely harmless but i still don't figure out
> > why this fixes the bug.  synth/emux/Makefile is:
> > 
> > snd-emux-synth-objs := emux.o emux_synth.o emux_seq.o emux_nrpn.o \
> > 		       emux_effect.o emux_proc.o soundfont.o
> > ifeq ($(CONFIG_SND_SEQUENCER_OSS),y)
> >   snd-emux-synth-objs += emux_oss.o
> > endif
> > 
> > # Toplevel Module Dependency
> > ifeq ($(subst m,y,$(CONFIG_SND_SEQUENCER)),y)
> >   obj-$(CONFIG_SND_SBAWE) += snd-emux-synth.o
> >   obj-$(CONFIG_SND_EMU10K1) += snd-emux-synth.o
> > endif
> > 
> > and if $CONFIG_SND_SEQUENCER is n, snd-emux-synth.o will be never
> > compiled nor built-in...
> 
> hummmm. must be some sort of "too late in the night to compile a
> kernel" workaround for a broken make rule (was not able to build
> emux/built-in.o if i remember right)

looking at the thread on lkml, it seems that we need at least one
non-empty obj-* definition.  changing synth/emux/Makefile is also a
hack...

anyway your patch is a workaround until Makefile.kbuild is fixed.
i'll apply it.


Takashi


-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility 
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/