From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: PM issue with Intel SST Atom driver Date: Mon, 24 Apr 2017 11:43:47 +0200 Message-ID: References: <20170424050144.GG6263@localhost> <20170424091213.GO6263@localhost> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id 687A4265DB7 for ; Mon, 24 Apr 2017 11:43:48 +0200 (CEST) In-Reply-To: <20170424091213.GO6263@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul Cc: Liam Girdwood , alsa-devel@alsa-project.org, Pierre-Louis Bossart List-Id: alsa-devel@alsa-project.org On Mon, 24 Apr 2017 11:12:14 +0200, Vinod Koul wrote: > > On Mon, Apr 24, 2017 at 11:00:45AM +0200, Takashi Iwai wrote: > > > Removing ignore_suspend makes the PM succeeds. But it hits some other > > ugly kernel bugs. > > Okay have you marked .nonatomic = true for the machine DAIs? Ah that's it. The patch below seems fixing the PM and the nonatomic problems. I'm not sure about the nonatomic flag for the compress stream, though. Also I fiddled only with FE. Do we need the same flags for BE? The others don't look setting like that, so I left so. thanks, Takashi --- sound/soc/intel/boards/bytcr_rt5640.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -646,7 +646,7 @@ static struct snd_soc_dai_link byt_rt564 .codec_dai_name = "snd-soc-dummy-dai", .codec_name = "snd-soc-dummy", .platform_name = "sst-mfld-platform", - .ignore_suspend = 1, + .nonatomic = true, .dynamic = 1, .dpcm_playback = 1, .dpcm_capture = 1, @@ -659,7 +659,6 @@ static struct snd_soc_dai_link byt_rt564 .codec_dai_name = "snd-soc-dummy-dai", .codec_name = "snd-soc-dummy", .platform_name = "sst-mfld-platform", - .ignore_suspend = 1, .nonatomic = true, .dynamic = 1, .dpcm_playback = 1, @@ -672,6 +671,7 @@ static struct snd_soc_dai_link byt_rt564 .codec_dai_name = "snd-soc-dummy-dai", .codec_name = "snd-soc-dummy", .platform_name = "sst-mfld-platform", + .nonatomic = true, }, /* back ends */ {