From: Takashi Iwai <tiwai@suse.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: patches.audio@intel.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda - fix whitespaces
Date: Thu, 09 Jun 2016 08:34:20 +0200 [thread overview]
Message-ID: <s5hh9d2c1lf.wl-tiwai@suse.de> (raw)
In-Reply-To: <1465453364-24323-1-git-send-email-vinod.koul@intel.com>
On Thu, 09 Jun 2016 08:22:44 +0200,
Vinod Koul wrote:
>
> Some trailing whitespaces seems to have crept in the hda_intel.c,
> so fix them up
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Well, this kind of "fix" doesn't improve readability but often makes
stable backporting harder. So I'd like to skip it.
This, of course, depends on the state of the code: for the code that
is being actively rewritten, it's good to have such fixes. OTOH, for
the longly maintained code, it's not clear whether to apply or not.
thanks,
Takashi
> ---
> sound/pci/hda/hda_intel.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 94089fc71884..5520082ad770 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -383,8 +383,8 @@ static char *driver_short_names[] = {
> [AZX_DRIVER_SIS] = "HDA SIS966",
> [AZX_DRIVER_ULI] = "HDA ULI M5461",
> [AZX_DRIVER_NVIDIA] = "HDA NVidia",
> - [AZX_DRIVER_TERA] = "HDA Teradici",
> - [AZX_DRIVER_CTX] = "HDA Creative",
> + [AZX_DRIVER_TERA] = "HDA Teradici",
> + [AZX_DRIVER_CTX] = "HDA Creative",
> [AZX_DRIVER_CTHDA] = "HDA Creative",
> [AZX_DRIVER_CMEDIA] = "HDA C-Media",
> [AZX_DRIVER_GENERIC] = "HD-Audio Generic",
> --
> 1.9.1
>
next prev parent reply other threads:[~2016-06-09 6:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 6:22 [PATCH] ALSA: hda - fix whitespaces Vinod Koul
2016-06-09 6:34 ` Takashi Iwai [this message]
2016-06-09 9:50 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hh9d2c1lf.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=patches.audio@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.