From: Takashi Iwai <tiwai@suse.de>
To: Eric Laurent <elaurent@google.com>
Cc: "Koul, Vinod" <vinod.koul@intel.com>, alsa-devel@alsa-project.org
Subject: Re: compress offload patch
Date: Fri, 04 Mar 2016 10:49:34 +0100 [thread overview]
Message-ID: <s5hh9gma7yp.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAL-7xP8m+p2XZHwM1y+KrH+FZUiux33dy6Y6LVEuAEiW6g5mDQ@mail.gmail.com>
On Thu, 03 Mar 2016 17:09:52 +0100,
Eric Laurent wrote:
>
> Takashi, Vinod,
>
> Can you help with merging the attached patch for compress offload core
> upstream?
Looks good to me, but I'm waiting for ack from Vinod.
BTW, I noticed that SNDRV_PCM_STREAM_PREPARED is missing in the
comment in snd_compr_open(). Should be fixed in another patch.
thanks,
Takashi
>
> Thanks.
>
> Eric.
> [1.2 <text/html; UTF-8 (7bit)>]
>
> From 1166adf4b63ea3ee1d119c46d97fa65c76a08447 Mon Sep 17 00:00:00 2001
> From: Eric Laurent <elaurent@google.com>
> Date: Wed, 2 Mar 2016 09:54:57 -0800
> Subject: [PATCH] ALSA: compress: allow writes in SNDRV_PCM_STATE_PREPARED
> state
>
> Allow writes in SNDRV_PCM_STATE_PREPARED state so that more
> than one buffer fragment can be written from user space
> before calling SNDRV_COMPRESS_START.
>
> Signed-off-by: Eric Laurent <elaurent@google.com>
> ---
> sound/core/compress_offload.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 1b77852..7c57f37 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -281,6 +281,7 @@ static ssize_t snd_compr_write(struct file *f, const char __user *buf,
> mutex_lock(&stream->device->lock);
> /* write is allowed when stream is running or has been steup */
> if (stream->runtime->state != SNDRV_PCM_STATE_SETUP &&
> + stream->runtime->state != SNDRV_PCM_STATE_PREPARED &&
> stream->runtime->state != SNDRV_PCM_STATE_RUNNING) {
> mutex_unlock(&stream->device->lock);
> return -EBADFD;
> --
> 2.7.0.rc3.207.g0ac5344
>
next prev parent reply other threads:[~2016-03-04 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 16:09 compress offload patch Eric Laurent
2016-03-04 9:49 ` Takashi Iwai [this message]
2016-03-04 13:52 ` Vinod Koul
2016-03-04 13:51 ` Takashi Iwai
2016-03-04 16:50 ` Eric Laurent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hh9gma7yp.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=elaurent@google.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.