All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Pavel Hofman <pavel.hofman@ivitera.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/6] AK4114 - fix output selector bits, fix spelling
Date: Tue, 15 Sep 2009 14:31:34 +0200	[thread overview]
Message-ID: <s5hhbv4bd95.wl%tiwai@suse.de> (raw)
In-Reply-To: <4AAF7FB4.7020401@ivitera.com>

At Tue, 15 Sep 2009 13:51:16 +0200,
Pavel Hofman wrote:
> 
> Takashi Iwai wrote:
> > At Tue, 15 Sep 2009 00:44:58 +0200,
> > pavel.hofman@ivitera.com wrote:
> >> From: Pavel Hofman <pavel.hofman@ivitera.com>
> >>
> >>
> >> Signed-off-by: Pavel Hofman <pavel.hofman@ivitera.com>
> > 
> > Could you give a bit more changelog content?
> > The summary line isn't enough for non-trivial changes.
> > In this case, you changed AK4114_OPS1[012] values without any
> > explanation.  Please give a bit more information, what these changes
> > mean, what impact they have, etc.
> 
> Sure, I was not sure how the rules apply in git. The first line in
> rebase/patch edit is a summary statement and next lines are the detailed
> changelog? Thanks a lot for the info.

Yes, the first line is the summary, then a blank line.
The rest are changelogs, and your sign-off.

Don't forget to put changelogs to each commit.  A longer description
is much much better than no description :)


thanks,

Takashi

      reply	other threads:[~2009-09-15 12:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14 22:44 [PATCH 1/6] AK4114 - fix output selector bits, fix spelling pavel.hofman
2009-09-14 22:44 ` [PATCH 2/6] ak4620 support, moving the proc codec regs entry to ak4xxx-adda, pavel.hofman
2009-09-14 22:45   ` [PATCH 3/6] ak4113 support pavel.hofman
2009-09-14 22:45     ` [PATCH 4/6] Adding GPIO routines for mask and direction pavel.hofman
2009-09-14 22:45       ` [PATCH 5/6] adding support for multiple external clock types pavel.hofman
2009-09-14 22:45         ` [PATCH 6/6] Infrasonic Quartet support pavel.hofman
2009-09-15 11:36           ` Takashi Iwai
2009-09-15 11:24         ` [PATCH 5/6] adding support for multiple external clock types Takashi Iwai
2009-09-15 13:09           ` Pavel Hofman
2009-09-15 13:29             ` Takashi Iwai
2009-09-15 11:19       ` [PATCH 4/6] Adding GPIO routines for mask and direction Takashi Iwai
2009-09-15 11:55         ` Pavel Hofman
2009-09-15 11:15     ` [PATCH 3/6] ak4113 support Takashi Iwai
2009-09-15 11:54       ` Pavel Hofman
2009-09-15 11:12   ` [PATCH 2/6] ak4620 support, moving the proc codec regs entry to ak4xxx-adda, Takashi Iwai
2009-09-15 11:07 ` [PATCH 1/6] AK4114 - fix output selector bits, fix spelling Takashi Iwai
2009-09-15 11:51   ` Pavel Hofman
2009-09-15 12:31     ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hhbv4bd95.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=pavel.hofman@ivitera.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.