All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: alsa-devel@alsa-project.org,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: ASoC: Au12x0/Au1550 PSC Audio support.
Date: Wed, 09 Jul 2008 19:48:00 +0200	[thread overview]
Message-ID: <s5hhcazymnj.wl%tiwai@suse.de> (raw)
In-Reply-To: <20080708163637.GA5505@roarinelk.homelinux.net>

Hi,

there are still some minor Kconfig issues:

> --- /dev/null
> +++ b/sound/soc/au1x/Kconfig
> @@ -0,0 +1,36 @@
> +menu "SoC Audio for the Alchemy/AMD/RMI Au1xxx"
> +	depends on SOC_AU1200 || SOC_AU1550

Avoid menu.  If really needed, use rather menuconfig.

> +
> +##
> +## Au1200/Au1550 PSC + DBDMA
> +##
> +config SND_SOC_AU1XPSC
> +	tristate "SoC Audio for Au1200/Au1250/Au1550"
> +	depends on SND_SOC && (SOC_AU1200 || SOC_AU1550)

As mentioned earlier, dependency on SND_SOC is superfluous here.


Could you fix and repost?

thanks,

Takashi

  parent reply	other threads:[~2008-07-09 13:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-03  7:33 ASoC: AC97 codec PM Manuel Lauss
2008-07-03  9:29 ` Liam Girdwood
2008-07-03  9:53   ` Manuel Lauss
2008-07-03  9:55     ` Liam Girdwood
2008-07-03 10:09       ` ASoC: Au12x0/Au1550 PSC Audio support Manuel Lauss
2008-07-04 15:13         ` Takashi Iwai
2008-07-04 16:24           ` Manuel Lauss
2008-07-04 17:36             ` Liam Girdwood
2008-07-07 16:05               ` Takashi Iwai
2008-07-07 16:09                 ` Liam Girdwood
2008-07-07 16:11                   ` Takashi Iwai
2008-07-07 17:15                   ` Manuel Lauss
2008-07-07 17:38                   ` Manuel Lauss
2008-07-08 15:13                     ` Liam Girdwood
2008-07-08 16:36                       ` Manuel Lauss
2008-07-09  5:34                         ` Manuel Lauss
2008-07-09 17:48                         ` Takashi Iwai [this message]
2008-07-09 14:27                           ` Manuel Lauss
2008-07-09 14:55                             ` Liam Girdwood
2008-07-09 19:27                             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hhcazymnj.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=mano@roarinelk.homelinux.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.