Re: [PATCH] asihpi driver, adds tuner controls, AESEBU controls, bus master support where available

[Takashi Iwai <tiwai@suse.de>]

At Wed, 27 Jul 2005 22:17:54 -0700,
Delio Brignoli wrote:
> 
> Hello,
> 
> > RETURN_IF_NEG() is a bit ugly.  In your code, it's not clear whether
> > this is for a debug purpose or for checking a critical error.
> > 
> > If it's just a check, you can use snd_assert().  Otherwise, a plain
> > if() would be easier to read.
> > 
> > Could you rewrite that stuff?
> 
> I've used snd_runtime_check ( thanks for pointing me at it )

Thanks.

I found other subtle things in the new patch.

  inline int ctl_add( snd_card_t * card, snd_kcontrol_new_t * ctl, snd_card_asihpi_t * asihpi ) {

should be static inline.

  void asihpi_ctl_name_prefix( snd_kcontrol_new_t * snd_control, hpi_control_t * asihpi_control) {

should be static, too.


> I'm attaching a new patch with some extra features:
> 
> Thu Jul 28 17:03:28 NZST 2005  dbrignoli@audioscience.com
>   * added_enable_bbm_module_param
> Thu Jul 28 16:50:46 NZST 2005  dbrignoli@audioscience.com
>   * use_alsa_debug_assertions_and_printd
> Tue Jul 26 18:15:11 NZST 2005  dbrignoli@audioscience.com
>   * fixed_bus_master_buffer_size_calculation
> Tue Jul 26 18:13:50 NZST 2005  dbrignoli@audioscience.com
>   * fixed_HPI_error_handling_macro_to_include_filename
> Fri Jul 22 16:37:16 NZST 2005  dbrignoli@audioscience.com
>   * add AESEBU controls to alsa mixer
> Fri Jul 22 12:33:22 NZST 2005  dbrignoli@audioscience.com
>   * enable_HPI_stream_host_buffers_if_supported
> Thu Jul 21 16:03:58 NZST 2005  dbrignoli@audioscience.com
>   * add_tuner_controls

Please put a full changelog to commit, and add signed-off-by line?


thanks,

Takashi


-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO September
19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf