Re: memory leaks?

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

At Tue, 29 Mar 2005 16:31:56 -0500,
Lee Revell wrote:
> 
> On Tue, 2005-03-29 at 15:24 -0500, Lee Revell wrote:
> > On Tue, 2005-03-29 at 14:27 +0200, Takashi Iwai wrote:
> > > Yes.  Could you trace the corresponding addresses?
> > > (just checking /proc/kallsyms before unloading would help, too).
> > 
> > How exactly would I trace those addresses?
> > 
> > Anyway, it looks to me that the leak is in snd_seq_midi.  Here is the
> > most recent output.  The first one I'm not sure about, the second seems
> > to be in snd_seq_midisynth_register_port.
> 
> I might have found it.  The info structure allocated in
> snd_seq_midisynth_register_port does not seem to be freed in
> snd_seq_midisynth_unregister_port, except on the error paths.

Nice catch.  Does the patch below fix the problem?


Takashi

[-- Attachment #2: Type: text/plain, Size: 506 bytes --]

Index: alsa-kernel/core/seq/seq_midi.c
===================================================================
RCS file: /home/iwai/cvs/alsa/alsa-kernel/core/seq/seq_midi.c,v
retrieving revision 1.26
diff -u -r1.26 seq_midi.c
--- alsa-kernel/core/seq/seq_midi.c	22 Mar 2005 15:21:18 -0000	1.26
+++ alsa-kernel/core/seq/seq_midi.c	30 Mar 2005 12:07:12 -0000
@@ -414,6 +414,7 @@
 	if (newclient)
 		synths[card->number] = client;
 	up(&register_mutex);
+	kfree(info);
 	return 0;	/* success */
 
       __nomem: