From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: build error in pcm_native.c
Date: Fri, 16 Jul 2004 15:15:12 +0200
Sender: alsa-devel-admin@lists.sourceforge.net
Message-ID: <s5hhds86qlb.wl@alsa2.suse.de>
References: <200407161357.56902@goldspace.net>
	<200407161441.40443@goldspace.net>
	<s5hllhk6t2d.wl@alsa2.suse.de>
	<200407161657.23244@goldspace.net>
	<s5hisco6qwx.wl@alsa2.suse.de>
Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen")
Content-Type: multipart/mixed;
 boundary="Multipart_Fri_Jul_16_15:15:12_2004-1"
Return-path: <alsa-devel-admin@lists.sourceforge.net>
In-Reply-To: <s5hisco6qwx.wl@alsa2.suse.de>
Errors-To: alsa-devel-admin@lists.sourceforge.net
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Post: <mailto:alsa-devel@lists.sourceforge.net>
List-Help: <mailto:alsa-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/alsa-devel>,
	<mailto:alsa-devel-request@lists.sourceforge.net?subject=subscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=alsa-devel>
To: Andrew Gaydenko <a@etver.com>
Cc: alsa-devel@lists.sourceforge.net
List-Id: alsa-devel@alsa-project.org

--Multipart_Fri_Jul_16_15:15:12_2004-1
Content-Type: text/plain; charset=US-ASCII

At Fri, 16 Jul 2004 15:08:14 +0200,
I wrote:
> 
> At Fri, 16 Jul 2004 16:57:23 +0400,
> Andrew Gaydenko wrote:
> > 
> > clean/(re)cvscompile were done.
> > 
> > I'm not bash guru, but from common view some configure fragment seems
> > strange to me. I have got
> > 
> > checking for new remap_page_range... "no"
> 
> You have an old version of kernel, don't you?
> 
> > Here 1 is assigned to new_remap (line 2). But CONFIG_OLD_REMAP_PAGE_RANGE
> > is defined (line 8) only when new_remap equals 0 (line 6).  Must new_remap 
> > assignement be reverted?
> 
> It defines CONFIG_ *OLD* _REMAP_PAGE_RANGE.  So it's correct.

Doh, I found you're right, the 1 and 0 are reverted.
And another silly typo.  The corrected (additional) patch is below.


Takashi

--Multipart_Fri_Jul_16_15:15:12_2004-1
Content-Type: text/plain; charset=US-ASCII

Index: alsa-driver/configure.in
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-driver/configure.in,v
retrieving revision 1.185
diff -u -r1.185 configure.in
--- alsa-driver/configure.in	16 Jul 2004 10:29:13 -0000	1.185
+++ alsa-driver/configure.in	16 Jul 2004 13:13:38 -0000
@@ -1311,12 +1311,12 @@
   func = remap_page_range;
   remap_page_range(NULL, 0, 0, 0, p);
 ],
-    AC_MSG_RESULT("yes");new_remap="0",
-    AC_MSG_RESULT("no");new_remap="1",
-    AC_MSG_RESULT("unknown");new_remap="1"
+    AC_MSG_RESULT("yes");new_remap="1",
+    AC_MSG_RESULT("no");new_remap="0",
+    AC_MSG_RESULT("unknown");new_remap="0"
 )
 CFLAGS=$ac_save_CFLAGS
-if test "new_remap" = "0"; then
+if test "$new_remap" != "1"; then
   AC_DEFINE(CONFIG_OLD_REMAP_PAGE_RANGE)
 fi
 

--Multipart_Fri_Jul_16_15:15:12_2004-1--


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click