From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8B6BC47096 for ; Sun, 6 Jun 2021 08:06:12 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 649656121E for ; Sun, 6 Jun 2021 08:06:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 649656121E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 235A316BA; Sun, 6 Jun 2021 10:05:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 235A316BA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1622966769; bh=7MykCFOjCPppb6IkPtwaeP2pWW+6OEqmKuK7KOqDZ8Y=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XKjunoqqD+GQIjcMg4vo/HLVolitTDaVEZUJNTHjbgNJxTcSUeF+W9mls7LCuW16d 6uDB47QzNpeT1yfr93dKqtXKAcWsb7dV6CrOKqQIuJgdB9g0xtWMte8LqzbYiXtujx n5YoZ86GbFXDdYB9J2lxBDvKV8lqgi3ZDL5OkunA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9C42DF8019B; Sun, 6 Jun 2021 10:05:18 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AC852F80218; Sun, 6 Jun 2021 10:05:16 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 29076F80103 for ; Sun, 6 Jun 2021 10:05:09 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 29076F80103 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="yeIwkCmq"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="zeMhKaVT" Received: from relay2.suse.de (unknown [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 74DB71FDA5; Sun, 6 Jun 2021 08:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622966709; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HuPWFO+tVpFLKGRhDYByJBx3FJIHpP/sXcCOTw9MB4U=; b=yeIwkCmqXv1BSPVBRauhBOllkYMvOot5/g3oCp/2B3ds29vZqzgdQvwx0xLdIDqNubhlNj A255G3Y7B86+CjZ5IjJbp5RYtkTvIJwyfceBPeQNXeQG/um3RjgGtD5QBne3WBBvrmokhy YuBSR1PnPEVATyCubDhKyOOWycgEW1E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622966709; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HuPWFO+tVpFLKGRhDYByJBx3FJIHpP/sXcCOTw9MB4U=; b=zeMhKaVTtTDfX78bwZDPbmG6AQNv/7/FSkgWM71SSBfV4TQFNCuR+XgU3/R5n/Pm1Nkoty 0cJ1pZMpMN8VUgDw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 4033CA3B81; Sun, 6 Jun 2021 08:05:09 +0000 (UTC) Date: Sun, 06 Jun 2021 10:05:09 +0200 Message-ID: From: Takashi Iwai To: Dan Carpenter Subject: Re: [PATCH] ALSA: firewire-lib: fix error codes for allocation failure In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, Clemens Ladisch , kernel-janitors@vger.kernel.org, Takashi Iwai X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, 05 Jun 2021 14:46:39 +0200, Dan Carpenter wrote: > > Return -ENOMEM if kcalloc() fails. Currently the code returns success. > > Fixes: f9e5ecdfc2c2 ("ALSA: firewire-lib: add replay target to cache sequence of packet") > Fixes: 6f24bb8a157c ("ALSA: firewire-lib: pool sequence of packet in IT context independently") > Signed-off-by: Dan Carpenter Thanks, applied. Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBE4C47096 for ; Sun, 6 Jun 2021 08:05:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C7946121E for ; Sun, 6 Jun 2021 08:05:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbhFFIG7 (ORCPT ); Sun, 6 Jun 2021 04:06:59 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:57432 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhFFIG7 (ORCPT ); Sun, 6 Jun 2021 04:06:59 -0400 Received: from relay2.suse.de (unknown [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 74DB71FDA5; Sun, 6 Jun 2021 08:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622966709; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HuPWFO+tVpFLKGRhDYByJBx3FJIHpP/sXcCOTw9MB4U=; b=yeIwkCmqXv1BSPVBRauhBOllkYMvOot5/g3oCp/2B3ds29vZqzgdQvwx0xLdIDqNubhlNj A255G3Y7B86+CjZ5IjJbp5RYtkTvIJwyfceBPeQNXeQG/um3RjgGtD5QBne3WBBvrmokhy YuBSR1PnPEVATyCubDhKyOOWycgEW1E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622966709; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HuPWFO+tVpFLKGRhDYByJBx3FJIHpP/sXcCOTw9MB4U=; b=zeMhKaVTtTDfX78bwZDPbmG6AQNv/7/FSkgWM71SSBfV4TQFNCuR+XgU3/R5n/Pm1Nkoty 0cJ1pZMpMN8VUgDw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id 4033CA3B81; Sun, 6 Jun 2021 08:05:09 +0000 (UTC) Date: Sun, 06 Jun 2021 10:05:09 +0200 Message-ID: From: Takashi Iwai To: Dan Carpenter Cc: Clemens Ladisch , Takashi Sakamoto , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] ALSA: firewire-lib: fix error codes for allocation failure In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On Sat, 05 Jun 2021 14:46:39 +0200, Dan Carpenter wrote: > > Return -ENOMEM if kcalloc() fails. Currently the code returns success. > > Fixes: f9e5ecdfc2c2 ("ALSA: firewire-lib: add replay target to cache sequence of packet") > Fixes: 6f24bb8a157c ("ALSA: firewire-lib: pool sequence of packet in IT context independently") > Signed-off-by: Dan Carpenter Thanks, applied. Takashi