From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FB67C4707F for ; Thu, 27 May 2021 06:26:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A24F7613DA for ; Thu, 27 May 2021 06:26:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A24F7613DA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 36072170B; Thu, 27 May 2021 08:25:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 36072170B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1622096784; bh=/1iDIgHh90C8tqDZhSNy4gPOhhr4RTngDWNA+/KBp10=; h=Date:From:To:Subject:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=EjEf8RVq7mt4V7zzhLDHtWorVNEZFhZEGDx4V0FEGvBXQfRzHqVptL8Fh7DXIfKqo jF1SVceIBgTlcgpl+imyzGp9hkll2u/mkU0N9wehtL7uwILXjyL0LPq3xOBAv5m1dA 9paYLK5S4WFdNpJupNtpDox6iwbIi+q/ebXKoj7o= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B9324F8012E; Thu, 27 May 2021 08:25:33 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id EBDBCF8025C; Thu, 27 May 2021 08:25:32 +0200 (CEST) Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B7A35F80116 for ; Thu, 27 May 2021 08:25:26 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B7A35F80116 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="y7nWazcF"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="JKq6Zxp7" X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622096726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hl1/Meu3baUR/pHArvTIths2m6R5HahAF0eEBwSqcfs=; b=y7nWazcFlpxWiR/wRCBjE7RN1Iy8VzR8iZjLDWR+5Mh07LNiLKhDkbDMC47rXVwe+3NZjv foDPCoPGZP+Pc4Z5m3aN7+o1SUTwMfeuVse7GtuPy9bbxoIVTdpIekpK+dKaPccKjBT668 BYVFOTPi7/qeAysXNNXs/MI2I0pwCQM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622096726; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Hl1/Meu3baUR/pHArvTIths2m6R5HahAF0eEBwSqcfs=; b=JKq6Zxp75ZwTxtDeIDAQLiLrJOPLfZI4e/sFvFVmj7AGEHp9iPcwC0mcRCAmMlcvDXR3Xf Uf5OSlxOOEjs8tBg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8288BAAA6; Thu, 27 May 2021 06:25:26 +0000 (UTC) Date: Thu, 27 May 2021 08:25:26 +0200 Message-ID: From: Takashi Iwai To: Pierre-Louis Bossart Subject: Re: [PATCH 1/2] ALSA: drivers: opl3: fix useless self-comparison In-Reply-To: <20210526192957.449515-1-pierre-louis.bossart@linux.intel.com> References: <20210526192957.449515-1-pierre-louis.bossart@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: alsa-devel@alsa-project.org, broonie@kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, 26 May 2021 21:29:56 +0200, Pierre-Louis Bossart wrote: > > Sparse throws the following warning: > > sound/drivers/opl3/opl3_midi.c:183:60: error: self-comparison always > evaluates to false > > This is likely a 16+ year old confusion between vp2 and vp. > > Suggested-by: Takashi Iwai > Signed-off-by: Pierre-Louis Bossart Thanks, applied. Takashi