From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F1EFCA9EAE for ; Tue, 29 Oct 2019 09:04:17 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A2152083E for ; Tue, 29 Oct 2019 09:04:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="bCGbzfbL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A2152083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6BC0E21C1; Tue, 29 Oct 2019 10:03:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6BC0E21C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572339854; bh=/z+blaAod6wbc6USft64JA8/EMgmJ4JMrgv/RTKsXTo=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bCGbzfbL4zG2EaYmXsv0J3ERcjJ9pp4WrehylPXFoK5Y0Mswg+UEo4NVFMETMQ9LP f1hZP+8Qv4N9atAnMEjsP9zo5PqcOQkcd+z7vZJ8KDlX2dM3RvuoODlJCNadrQEQ7a nPpP25FTEfd92YHhZb8fP60Q9VqwDtbfTfXCnups= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id C6A30F800E7; Tue, 29 Oct 2019 10:03:23 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2B3C2F80392; Tue, 29 Oct 2019 10:03:22 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7CF5EF800E7 for ; Tue, 29 Oct 2019 10:03:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7CF5EF800E7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D521FAD8C; Tue, 29 Oct 2019 09:03:17 +0000 (UTC) Date: Tue, 29 Oct 2019 10:03:16 +0100 Message-ID: From: Takashi Iwai To: Saurav Girepunje In-Reply-To: <20191029083509.GA8293@saurav> References: <20191029083509.GA8293@saurav> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, tiwai@suse.com, rfontana@redhat.com, saurav.girepunje@hotmail.com, tglx@linutronix.de, allison@lohutok.net Subject: Re: [alsa-devel] [PATCH] usb: clock.c : usb true/false for bool return type X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 29 Oct 2019 09:35:11 +0100, Saurav Girepunje wrote: > > Use true/false for bool type return in uac_clock_source_is_valid(). > > Signed-off-by: Saurav Girepunje > --- > sound/usb/clock.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/sound/usb/clock.c b/sound/usb/clock.c > index 6b8c14f9b5d4..8b8ab83fac0d 100644 > --- a/sound/usb/clock.c > +++ b/sound/usb/clock.c > @@ -165,21 +165,21 @@ static bool uac_clock_source_is_valid(struct snd_usb_audio *chip, > snd_usb_find_clock_source_v3(chip->ctrl_intf, source_id); > > if (!cs_desc) > - return 0; > + return false; > bmControls = le32_to_cpu(cs_desc->bmControls); > } else { /* UAC_VERSION_1/2 */ > struct uac_clock_source_descriptor *cs_desc = > snd_usb_find_clock_source(chip->ctrl_intf, source_id); > > if (!cs_desc) > - return 0; > + return false; > bmControls = cs_desc->bmControls; > } > > /* If a clock source can't tell us whether it's valid, we assume it is */ > if (!uac_v2v3_control_is_readable(bmControls, > UAC2_CS_CONTROL_CLOCK_VALID)) > - return 1; > + return true; > > err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), UAC2_CS_CUR, > USB_TYPE_CLASS | USB_RECIP_INTERFACE | USB_DIR_IN, > @@ -191,10 +191,10 @@ static bool uac_clock_source_is_valid(struct snd_usb_audio *chip, > dev_warn(&dev->dev, > "%s(): cannot get clock validity for id %d\n", > __func__, source_id); > - return 0; > + return false; > } > > - return !!data; > + return !!data ? true : false; This doesn't need the ternary operator here. Or drop "!!". (Actually it would work just return data without "!!" for bool type, but maybe it's still clearer to have it.) Also, please align the subject line with other commits. For USB-audio, it's "ALSA: usb-audio: Subject..." thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88656CA9EAE for ; Tue, 29 Oct 2019 09:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 550412083E for ; Tue, 29 Oct 2019 09:03:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730565AbfJ2JDU (ORCPT ); Tue, 29 Oct 2019 05:03:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:35266 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730528AbfJ2JDT (ORCPT ); Tue, 29 Oct 2019 05:03:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D521FAD8C; Tue, 29 Oct 2019 09:03:17 +0000 (UTC) Date: Tue, 29 Oct 2019 10:03:16 +0100 Message-ID: From: Takashi Iwai To: Saurav Girepunje Cc: perex@perex.cz, tiwai@suse.com, rfontana@redhat.com, gregkh@linuxfoundation.org, allison@lohutok.net, tglx@linutronix.de, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH] usb: clock.c : usb true/false for bool return type In-Reply-To: <20191029083509.GA8293@saurav> References: <20191029083509.GA8293@saurav> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Oct 2019 09:35:11 +0100, Saurav Girepunje wrote: > > Use true/false for bool type return in uac_clock_source_is_valid(). > > Signed-off-by: Saurav Girepunje > --- > sound/usb/clock.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/sound/usb/clock.c b/sound/usb/clock.c > index 6b8c14f9b5d4..8b8ab83fac0d 100644 > --- a/sound/usb/clock.c > +++ b/sound/usb/clock.c > @@ -165,21 +165,21 @@ static bool uac_clock_source_is_valid(struct snd_usb_audio *chip, > snd_usb_find_clock_source_v3(chip->ctrl_intf, source_id); > > if (!cs_desc) > - return 0; > + return false; > bmControls = le32_to_cpu(cs_desc->bmControls); > } else { /* UAC_VERSION_1/2 */ > struct uac_clock_source_descriptor *cs_desc = > snd_usb_find_clock_source(chip->ctrl_intf, source_id); > > if (!cs_desc) > - return 0; > + return false; > bmControls = cs_desc->bmControls; > } > > /* If a clock source can't tell us whether it's valid, we assume it is */ > if (!uac_v2v3_control_is_readable(bmControls, > UAC2_CS_CONTROL_CLOCK_VALID)) > - return 1; > + return true; > > err = snd_usb_ctl_msg(dev, usb_rcvctrlpipe(dev, 0), UAC2_CS_CUR, > USB_TYPE_CLASS | USB_RECIP_INTERFACE | USB_DIR_IN, > @@ -191,10 +191,10 @@ static bool uac_clock_source_is_valid(struct snd_usb_audio *chip, > dev_warn(&dev->dev, > "%s(): cannot get clock validity for id %d\n", > __func__, source_id); > - return 0; > + return false; > } > > - return !!data; > + return !!data ? true : false; This doesn't need the ternary operator here. Or drop "!!". (Actually it would work just return data without "!!" for bool type, but maybe it's still clearer to have it.) Also, please align the subject line with other commits. For USB-audio, it's "ALSA: usb-audio: Subject..." thanks, Takashi