From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B32B7CA9EC0 for ; Mon, 28 Oct 2019 13:56:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38182214D9 for ; Mon, 28 Oct 2019 13:56:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="pQRsMQo4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38182214D9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2AD2A1F32; Mon, 28 Oct 2019 14:56:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2AD2A1F32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572271011; bh=NUDoKgC28CIQ1m35ecNvXmN7jt0lHfwiiHjIplVNpo4=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pQRsMQo4BCPOjTEQ/6MBfGh1khRJc7HCuV2vw7c9ahlxw3ytDQ8aX9N159YIhOD6G CP2IZqLJMb8W+Dr9034uHZpIshfoSr3K3u00yGnOj7U+KW5T3F5CNtFgerZ0n3t6ss ZRD6YKrrj+ZHNmBGERx65/AMizqkMr5LfWd7D7WA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id A2DE5F802BD; Mon, 28 Oct 2019 14:56:00 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 732DBF80361; Mon, 28 Oct 2019 14:55:58 +0100 (CET) Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 42EDBF80145 for ; Mon, 28 Oct 2019 14:55:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 42EDBF80145 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B29BFAEFB; Mon, 28 Oct 2019 13:55:54 +0000 (UTC) Date: Mon, 28 Oct 2019 14:55:52 +0100 Message-ID: From: Takashi Iwai To: Greg KH In-Reply-To: <20191028133050.GA13691@kroah.com> References: <000000000000f838060595f602a7@google.com> <20191028133050.GA13691@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org, wang6495@umn.edu, yuehaibing@huawei.com, tiwai@suse.com, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org, glider@google.com, allison@lohutok.net, syzbot , tglx@linutronix.de, benquike@gmail.com, dan.carpenter@oracle.com Subject: Re: [alsa-devel] KMSAN: uninit-value in get_term_name X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Mon, 28 Oct 2019 14:30:50 +0100, Greg KH wrote: > > On Mon, Oct 28, 2019 at 02:13:20PM +0100, Takashi Iwai wrote: > > On Mon, 28 Oct 2019 11:32:07 +0100, > > syzbot wrote: > > > > > > Uninit was stored to memory at: > > > kmsan_save_stack_with_flags mm/kmsan/kmsan.c:151 [inline] > > > kmsan_internal_chain_origin+0xbd/0x180 mm/kmsan/kmsan.c:319 > > > __msan_chain_origin+0x6b/0xd0 mm/kmsan/kmsan_instr.c:179 > > > parse_term_proc_unit+0x73d/0x7e0 sound/usb/mixer.c:896 > > > __check_input_term+0x13ef/0x2360 sound/usb/mixer.c:989 > > > > So this comes from the invalid descriptor for a processing unit, and > > it's very likely the same issue as already spotted -- the validator up > > to 5.3-rc4 had a bug that passed the invalid descriptor falsely. > > This should have been covered by 5.3-rc5, commit ba8bf0967a15 ("ALSA: > > usb-audio: Fix copy&paste error in the validator"). > > SHould we be backporting the validator to any older kernels as well? Yes, that would be nice. I didn't mark them for stable just because they are a bit largish and wanted to let them tested for 5.4 for a while. The following commits are relevant (from top/old to bottom/new). 57f8770620e9b51c61089751f0b5ad3dbe376ff2 ALSA: usb-audio: More validations of descriptor units 68e9fde245591d18200f8a9054cac22339437adb ALSA: usb-audio: Simplify parse_audio_unit() 52c3e317a857091fd746e15179a637f32be4d337 ALSA: usb-audio: Unify the release of usb_mixer_elem_info objects b8e4f1fdfa422398c2d6c47bfb7d1feb3046d70a ALSA: usb-audio: Remove superfluous bLength checks e0ccdef92653f8867e2d1667facfd3c23699f540 ALSA: usb-audio: Clean up check_input_term() 60849562a5db4a1eee2160167e4dce4590d3eafe ALSA: usb-audio: Fix possible NULL dereference at create_yamaha_midi_quirk() b39e077fcb283dd96dd251a3abeba585402c61fe ALSA: usb-audio: remove some dead code ba8bf0967a154796be15c4983603aad0b05c3138 ALSA: usb-audio: Fix copy&paste error in the validator thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64697CA9EC0 for ; Mon, 28 Oct 2019 13:55:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40766208C0 for ; Mon, 28 Oct 2019 13:55:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389674AbfJ1Nz5 (ORCPT ); Mon, 28 Oct 2019 09:55:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:54562 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727567AbfJ1Nz4 (ORCPT ); Mon, 28 Oct 2019 09:55:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B29BFAEFB; Mon, 28 Oct 2019 13:55:54 +0000 (UTC) Date: Mon, 28 Oct 2019 14:55:52 +0100 Message-ID: From: Takashi Iwai To: Greg KH Cc: syzbot , allison@lohutok.net, alsa-devel@alsa-project.org, benquike@gmail.com, dan.carpenter@oracle.com, glider@google.com, linux-kernel@vger.kernel.org, perex@perex.cz, syzkaller-bugs@googlegroups.com, tglx@linutronix.de, tiwai@suse.com, wang6495@umn.edu, yuehaibing@huawei.com Subject: Re: KMSAN: uninit-value in get_term_name In-Reply-To: <20191028133050.GA13691@kroah.com> References: <000000000000f838060595f602a7@google.com> <20191028133050.GA13691@kroah.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 28 Oct 2019 14:30:50 +0100, Greg KH wrote: > > On Mon, Oct 28, 2019 at 02:13:20PM +0100, Takashi Iwai wrote: > > On Mon, 28 Oct 2019 11:32:07 +0100, > > syzbot wrote: > > > > > > Uninit was stored to memory at: > > > kmsan_save_stack_with_flags mm/kmsan/kmsan.c:151 [inline] > > > kmsan_internal_chain_origin+0xbd/0x180 mm/kmsan/kmsan.c:319 > > > __msan_chain_origin+0x6b/0xd0 mm/kmsan/kmsan_instr.c:179 > > > parse_term_proc_unit+0x73d/0x7e0 sound/usb/mixer.c:896 > > > __check_input_term+0x13ef/0x2360 sound/usb/mixer.c:989 > > > > So this comes from the invalid descriptor for a processing unit, and > > it's very likely the same issue as already spotted -- the validator up > > to 5.3-rc4 had a bug that passed the invalid descriptor falsely. > > This should have been covered by 5.3-rc5, commit ba8bf0967a15 ("ALSA: > > usb-audio: Fix copy&paste error in the validator"). > > SHould we be backporting the validator to any older kernels as well? Yes, that would be nice. I didn't mark them for stable just because they are a bit largish and wanted to let them tested for 5.4 for a while. The following commits are relevant (from top/old to bottom/new). 57f8770620e9b51c61089751f0b5ad3dbe376ff2 ALSA: usb-audio: More validations of descriptor units 68e9fde245591d18200f8a9054cac22339437adb ALSA: usb-audio: Simplify parse_audio_unit() 52c3e317a857091fd746e15179a637f32be4d337 ALSA: usb-audio: Unify the release of usb_mixer_elem_info objects b8e4f1fdfa422398c2d6c47bfb7d1feb3046d70a ALSA: usb-audio: Remove superfluous bLength checks e0ccdef92653f8867e2d1667facfd3c23699f540 ALSA: usb-audio: Clean up check_input_term() 60849562a5db4a1eee2160167e4dce4590d3eafe ALSA: usb-audio: Fix possible NULL dereference at create_yamaha_midi_quirk() b39e077fcb283dd96dd251a3abeba585402c61fe ALSA: usb-audio: remove some dead code ba8bf0967a154796be15c4983603aad0b05c3138 ALSA: usb-audio: Fix copy&paste error in the validator thanks, Takashi