From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda - Fixes inverted Conexant GPIO mic mute led Date: Fri, 16 Aug 2019 09:11:44 +0200 Message-ID: References: <20190815013824.13373-1-jeronimo@borque.com.ar> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 97B3CF80110 for ; Fri, 16 Aug 2019 09:11:45 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: =?UTF-8?B?SmVyw7NuaW1v?= Borque Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org T24gRnJpLCAxNiBBdWcgMjAxOSAwMTowODozNCArMDIwMCwKSmVyw7NuaW1vIEJvcnF1ZSB3cm90 ZToKPiAKPiBFbCBqdWUuLCAxNSBkZSBhZ28uIGRlIDIwMTkgYSBsYShzKSAxNDowNiwgVGFrYXNo aSBJd2FpICh0aXdhaUBzdXNlLmRlKQo+IGVzY3JpYmnDszoKPiAKPiAgICAgT24gVGh1LCAxNSBB dWcgMjAxOSAxODozMzo1MCArMDIwMCwKPiAgICAgSmVyw7NuaW1vIEJvcnF1ZSB3cm90ZToKPiAg ICAgPgo+ICAgICA+IEhpIFRha2FzaGksCj4gICAgID4gTW9kaWZ5aW5nIE1pYyBNdXRlLUxFRCBN b2RlIGRvZXMgaW5kZWVkIGFsdGVyIHRoZSBiZWhhdmlvci4gVGhlIHRoaW5nIGlzCj4gICAgIHRo YXQKPiAgICAgPiB0aGlzIGVuZHMgYmVpbmcgY29uZnVzaW5nIGFzIGluIGFsbCBtYWNoaW5lcyBJ J3ZlIGJlZW4gdGVzdGluZyB0aGlzCj4gICAgIHNldHRpbmcKPiAgICAgPiBNaWMgTXV0ZS1MRUQg TW9kZSB0byAiRm9sbG93IENhcHR1cmUiIGFjdHVhbGx5IG1ha2VzIGl0IGZvbGxvdyBtdXRlLCBh cwo+ICAgICA+IHNldHRpbmcgaXQgdG8gIk9uIiB0dXJucyB0aGUgTEVEIG9mZi4KPiAgICAgPiBU aGVyZSBpcyBvdGhlciBzZXR0aW5nIGNhbGxlZCAibXV0ZV9sZWRfcG9sYXJpdHkiIGJ1dCB0aGlz IGRvZXMgbm90Cj4gICAgIHdvcmssIGFzCj4gICAgID4gY3VycmVudGx5IG1pYyBtdXRlIExFRCBh bmQgbXV0ZSBMRUQgZG8gbm90IGZvbGxvdyB0aGUgc2FtZSBsb2dpYy4KPiAgICAgPiBXaGF0IEkg dGhpbmsgbWF5IGJlIGNhdXNpbmcgY29uZnVzaW9uIGlzICJjeHRfdXBkYXRlX2dwaW9fbGVkIiAi ZW5hYmxlZCIKPiAgICAgPiBwYXJhbWV0ZXIuIFNldHRpbmcgImVuYWJsZWQiIHRvICJ0cnVlIiBz ZXRzIHRoZSBHUElPIHBpbiB0byAwIGNhdXNpbmcKPiAgICAgdGhlIGxlZAo+ICAgICA+IHRvIGJl IHR1cm5lZCBvZmYuIEkgdGhpbmsgImVuYWJsZWQiIHVzZWQgdG8gcmVmZXIgdG8gdGhlIGlucHV0 IGNhcHR1cmUKPiAgICAgb3IKPiAgICAgPiBvdXRwdXQgc3RhdHVzIGFuZCBub3QgdG8gdGhlIExF RCBiZWluZyBsaXQgb3Igbm90LiBPdXRwdXQgb3IgaW5wdXQgbm90Cj4gICAgIGVuYWJsZWQKPiAg ICAgPiAoZW5hYmxlZD09ZmFsc2UpIGNhdXNlZCB0aGUgTEVEIHRvIGJlIHR1cm5lZCBvbi4KPiAg ICAgPiBUaGlzIGxvZ2ljIGluIHRoZSBmdW5jdGlvbiBuZWdhdGVzIGl0IG9uIHRoZSBHUElPIG91 dHB1dC4KPiAgICAgPgo+ICAgICA+IGlmIChlbmFibGVkKQo+ICAgICA+IMKgwqDCoCBzcGVjLT5n cGlvX2xlZCAmPSB+bWFzazsKPiAgICAgPiBlbHNlCj4gICAgID4gwqDCoMKgIHNwZWMtPmdwaW9f bGVkIHw9IG1hc2s7Cj4gICAgID4KPiAgICAgPiBNYXkgYmUgSSBjYW4gZG8gYSBtb3JlIGNvbXBy ZWhlbnNpdmUgZml4LCByZXZlcnNpbmcgdGhlIGJlaGF2aW9yIG9mwqAKPiAgICAgPiAiY3h0X3Vw ZGF0ZV9ncGlvX2xlZCIgImVuYWJsZWQiIHBhcmFtZXRlciB0byByZWZlciB0aGUgR1BJTyBvdXRw dXQgdmFsdWUKPiAgICAgKAo+ICAgICA+IGVuYWJsZWQ9PXRydWUgPT4gR1BJTyBwaW4gb3V0cHV0 IGhpZ2ggKQo+ICAgICA+IFRoZW4gYWxzbyBtb2RpZnkgdGhlIGNhbGwgdG8gImN4dF91cGRhdGVf Z3Bpb19sZWQiIGluCj4gICAgID4gImN4dF9maXh1cF9ncGlvX211dGVfaG9vayIgdG8gbWFrZSBp dCB3b3JrIGNvbnNpc3RlbnRseS4KPiAgICAKPiAgICAgT0ssIGlmIHRoZSAiT24iIHR1cm5zIHRo ZSBMRUQgb2ZmLCBpdCdzIGluZGVlZCBpbnZlcnRlZC4KPiAgICAgVGhlbiB3ZSdkIG5lZWQgdG8g Y29uc2lkZXIgYm90aCBmaXhpbmcgdGhlIGludmVydGVkIGJlaGF2aW9yIGFuZCB0aGUKPiAgICAg ZGVmYXVsdCBtaWMtbXV0ZSBtb2RlLgo+ICAgIAo+ICAgICBDb3VsZCB5b3UgY29uZmlybSB0aGUg Zm9sbG93aW5nPwo+ICAgIAo+ICAgICAtIFdoaWNoIG1vZGVscyBhbmQgY29kZWNzIGFyZSBjaGVj a2VkPwo+IAo+IEkndmUgdGVzdGVkIG9uIEhQIFpCb29rIDE1VSBHMyAoQ29uZXhhbnQgQ1gyMDcy NCkgYW5kIEhQIFByb2Jvb2sgNDQwIEc0Cj4gKENvbmV4YW50IENYODIwMCkKPiAKPiAgICAgLSBH UElPIHBpbiBoaWdoID0gbWljIExFRCBvbiBvciBvZmY/Cj4gCj4gwqBHUElPIHBpbiBoaWdoID0g bWljIExFRCBvbgo+IAo+ICAgICAtIEhvdyBpcyB0aGUgZXhwZWN0ZWQgYmVoYXZpb3Igb24gV2lu ZG93cz8KPiAgICAgwqAgwqBNdXRlIGlzIG9uIHdoZW4gbWljIGlzIG11dGVkLMKgb3IgbXV0ZS1v biB3aGVuIG1pYyBpcyByZWFkeT8KPiAKPiBNdXRlIGxlZCBpcyBvbiB3aGVuIG1pYyBpcyBtdXRl ZC4KClRoYW5rcywgaXQncyBjbGVhcmVyIG5vdy4KClRoZW4gSSdkIHJhdGhlciBsaWtlIHRvIGNv cnJlY3QgY3h0X3VwZGF0ZV9ncGlvX2xlZCgpLCBpLmUuIHRha2luZyB0aGUKYXJndW1lbnQgbGVk X29uIGluc3RlYWQgb2YgZW5hYmxlZCwgYW5kIGNvcnJlY3QgdGhlIGNhbGxlciBpbgpjeHRfZml4 dXBfZ3Bpb19tdXRlX2hvb2soKSB0byBpbnZlcnQgaW5zdGVhZC4gIFNvbWV0aGluZyBsaWtlIGJl bG93LgpDb3VsZCB5b3UgcmV0ZXN0IGFuZCByZXN1Ym1pdCB3aXRoIHRoYXQgY2hhbmdlPwoKCnRo YW5rcywKClRha2FzaGkKCi0tLSBhL3NvdW5kL3BjaS9oZGEvcGF0Y2hfY29uZXhhbnQuYworKysg Yi9zb3VuZC9wY2kvaGRhL3BhdGNoX2NvbmV4YW50LmMKQEAgLTYxMSwxOCArNjExLDE4IEBAIHN0 YXRpYyB2b2lkIGN4dF9maXh1cF9ocF9nYXRlX21pY19qYWNrKHN0cnVjdCBoZGFfY29kZWMgKmNv ZGVjLAogCiAvKiB1cGRhdGUgTEVEIHN0YXR1cyB2aWEgR1BJTyAqLwogc3RhdGljIHZvaWQgY3h0 X3VwZGF0ZV9ncGlvX2xlZChzdHJ1Y3QgaGRhX2NvZGVjICpjb2RlYywgdW5zaWduZWQgaW50IG1h c2ssCi0JCQkJYm9vbCBlbmFibGVkKQorCQkJCWJvb2wgbGVkX29uKQogewogCXN0cnVjdCBjb25l eGFudF9zcGVjICpzcGVjID0gY29kZWMtPnNwZWM7CiAJdW5zaWduZWQgaW50IG9sZHZhbCA9IHNw ZWMtPmdwaW9fbGVkOwogCiAJaWYgKHNwZWMtPm11dGVfbGVkX3BvbGFyaXR5KQotCQllbmFibGVk ID0gIWVuYWJsZWQ7CisJCWxlZF9vbiA9ICFsZWRfb247CiAKLQlpZiAoZW5hYmxlZCkKLQkJc3Bl Yy0+Z3Bpb19sZWQgJj0gfm1hc2s7Ci0JZWxzZQorCWlmIChsZWRfb24pCiAJCXNwZWMtPmdwaW9f bGVkIHw9IG1hc2s7CisJZWxzZQorCQlzcGVjLT5ncGlvX2xlZCAmPSB+bWFzazsKIAlpZiAoc3Bl Yy0+Z3Bpb19sZWQgIT0gb2xkdmFsKQogCQlzbmRfaGRhX2NvZGVjX3dyaXRlKGNvZGVjLCAweDAx LCAwLCBBQ19WRVJCX1NFVF9HUElPX0RBVEEsCiAJCQkJICAgIHNwZWMtPmdwaW9fbGVkKTsKQEAg LTYzNCw3ICs2MzQsOCBAQCBzdGF0aWMgdm9pZCBjeHRfZml4dXBfZ3Bpb19tdXRlX2hvb2sodm9p ZCAqcHJpdmF0ZV9kYXRhLCBpbnQgZW5hYmxlZCkKIAlzdHJ1Y3QgaGRhX2NvZGVjICpjb2RlYyA9 IHByaXZhdGVfZGF0YTsKIAlzdHJ1Y3QgY29uZXhhbnRfc3BlYyAqc3BlYyA9IGNvZGVjLT5zcGVj OwogCi0JY3h0X3VwZGF0ZV9ncGlvX2xlZChjb2RlYywgc3BlYy0+Z3Bpb19tdXRlX2xlZF9tYXNr LCBlbmFibGVkKTsKKwkvKiBtdXRlZCAtPiBMRUQgb24gKi8KKwljeHRfdXBkYXRlX2dwaW9fbGVk KGNvZGVjLCBzcGVjLT5ncGlvX211dGVfbGVkX21hc2ssICFlbmFibGVkKTsKIH0KIAogLyogdHVy biBvbi9vZmYgbWljLW11dGUgTEVEIHZpYSBHUElPIHBlciBjYXB0dXJlIGhvb2sgKi8KX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWxzYS1kZXZlbCBtYWls aW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHBzOi8vbWFpbG1hbi5hbHNh LXByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo=