From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda: Fix a headphone detection issue when using SOF Date: Mon, 01 Jul 2019 16:14:58 +0200 Message-ID: References: <20190701074630.51472-1-rander.wang@linux.intel.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 5E19EF8076A for ; Mon, 1 Jul 2019 16:14:58 +0200 (CEST) In-Reply-To: <20190701074630.51472-1-rander.wang@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Rander Wang Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, 01 Jul 2019 09:46:30 +0200, Rander Wang wrote: > > To save power, the hda hdmi driver in ASoC invokes snd_hdac_ext_bus_link_put > to disable CORB/RIRB buffers DMA if there is no user of bus and invokes > snd_hdac_ext_bus_link_get to set up CORB/RIRB buffers when it is used. > Unsolicited responses is disabled in snd_hdac_bus_stop_cmd_io called by > snd_hdac_ext_bus_link_put , but it is not enabled in snd_hdac_bus_init_cmd_io > called by snd_hdac_ext_bus_link_get. So for put-get sequence, Unsolicited > responses is disabled and headphone can't be detected by hda codecs. > > Now unsolicited responses is only enabled in snd_hdac_bus_reset_link > which resets controller. The function is only called for setup of > controller. This patch enables Unsolicited responses after RIRB is > initialized in snd_hdac_bus_init_cmd_io which works together with > snd_hdac_bus_reset_link to set up controller. > > Tested legacy hda driver and SOF driver on intel whiskeylake. > > Reviewed-by: Takashi Iwai > Signed-off-by: Rander Wang Applied now. Thanks. Takashi