From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda/hdmi - Don't report Jack event if no need to do that Date: Fri, 03 May 2019 17:57:31 +0200 Message-ID: References: <20190430065711.14977-1-hui.wang@canonical.com> <1be4853e-05cd-fc87-8db6-7ba17ee009ab@canonical.com> <4611984b-c80f-8aa4-a760-72343572470e@canonical.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.suse.de (mx2.suse.de [195.135.220.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 78BC8F8075A for ; Fri, 3 May 2019 17:57:32 +0200 (CEST) In-Reply-To: <4611984b-c80f-8aa4-a760-72343572470e@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Hui Wang Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org T24gRnJpLCAwMyBNYXkgMjAxOSAwNjowNTowOSArMDIwMCwKSHVpIFdhbmcgd3JvdGU6Cj4gCj4g Cj4gT24gMjAxOS81LzIg5LiL5Y2IMTE6NDksIFRha2FzaGkgSXdhaSB3cm90ZToKPiA+IE9uIFRo dSwgMDIgTWF5IDIwMTkgMDQ6NTI6NDYgKzAyMDAsCj4gPiBIdWkgV2FuZyB3cm90ZToKPiA+Pgo+ ID4+IE9uIDIwMTkvNC8zMCDkuIvljYg1OjAyLCBUYWthc2hpIEl3YWkgd3JvdGU6Cj4gPj4+IE9u IFR1ZSwgMzAgQXByIDIwMTkgMTA6NDI6NTUgKzAyMDAsCj4gPj4+IEh1aSBXYW5nIHdyb3RlOgo+ ID4+Pj4gT24gMjAxOS80LzMwIOS4i+WNiDM6MzUsIFRha2FzaGkgSXdhaSB3cm90ZToKPiA+Pj4+ PiBPbiBUdWUsIDMwIEFwciAyMDE5IDA4OjU3OjExICswMjAwLAo+ID4+Pj4+IEh1aSBXYW5nIHdy b3RlOgo+ID4+Pj4+PiBPbiB0aGUgbWFjaGluZXMgd2l0aCBBTUQgR1BVIG9yIE52aWRpYSBHUFUs IHdlIG9mdGVuIG1lZXQgdGhpcyBpc3N1ZXM6Cj4gPj4+Pj4+IGFmdGVyIHMzLCB0aGVyZSBhcmUg NCBIRE1JL0RQIGF1ZGlvIGRldmljZXMgaW4gdGhlIGdub21lLXNvdW5kLXNldHRpbmcKPiA+Pj4+ Pj4gZXZlbiB0aGVyZSBpcyBubyBhbnkgbW9uaXRvcnMgcGx1Z2dlZC4KPiA+Pj4+Pj4KPiA+Pj4+ Pj4gV2hlbiB0aGlzIHByb2JsZW0gaGFwcGVucywgd2UgY2hlY2sgdGhlIC9wcm9jL2Fzb3VuZC9j YXJkWC9lbGQjTi5NLCB3ZQo+ID4+Pj4+PiB3aWxsIGZpbmQgdGhlIG1vbml0b3JfcHJlc2VudD0x LCBlbGRfdmFsaWQ9MC4KPiA+Pj4+Pj4KPiAKPiA+Pj4+Pj4KPiA+Pj4+Pj4gU28gdGhlIGZpeCBp cyBwdXR0aW5nIHlvdXIgY2hhbmdlIGFuZCBteSBjaGFuZ2UgdG9nZXRoZXIgbGlrZSBiZWxvdz8K PiA+IFdlbGwsIHJlbW92aW5nICIhcmVwb2xsIiBzaG91bGQgYmUgdHJlYXRlZCBhcyBhIHNlcGFy YXRlIHBhdGNoLCBhbmQKPiA+IEknbSBub3Qgc3VyZSB3aGV0aGVyIHdlIHdhbnQgdG8gZ2V0IHJp ZCBvZiBpdC4KPiA+Cj4gPiBUaGUgIiFyZXBvbGwiIGNoZWNrIGlzIGEgYml0IG1pc2xlYWRpbmcu ICBUaGlzIGNvbmRpdGlvbiBpbmRpY2F0ZXMKPiA+IHRoYXQgdGhlIGphY2sgc3RhdHVzIHN5bmMg aXMgcmVxdWlyZWQsIGUuZy4gaXQncyB0aGUgY2FzZSB3aGVyZQo+ID4gcG9sbGluZyBnb2VzIHRv IHRpbWVvdXQgb3IgYXQgdGhlIGJlZ2lubmluZyBvZiB0aGUgcHJvYmUuICBGb3IKPiA+IGV4YW1w bGUsIGluIHRoZSBjYXNlIG9mIHJlc3VtZSwgaXQgc3RhcnRzIHdpdGggcmVwb2xsPTEuICBJZiBh bgo+ID4gaW5jb21wbGV0ZSBzdGF0ZSAobW9uaXRvcj0xLCBlbGRfdmFsaWQ9MCkgaXMgc2VlbiBh dCB0aGlzIHBvaW50LCB0aGUKPiA+IGNvZGUgc2NoZWR1bGVzIGZvciB0aGUgcmV0cnkgYXQgYSBs YXRlciBwb2ludC4gIEFuZCBpZiBpdCByZWFjaGVzIHRvCj4gPiB0aGUgbWF4IGNvdW50LCBpdCBj bGVhcnMgdG8gcmVwb2xsPTAgYW5kIHRyeSB0aGUgbGFzdCBhdHRlbXB0LCB3aGljaAo+ID4gd29u J3Qgc2NoZWR1bGUgYW55IGxvbmdlci4KPiA+Cj4gPiBTbywgYXQgdGhpcyBwb2ludCwgd2UgKmhh dmUgdG8qIG5vdGlmeSB0aGUgcmVzdWx0IG5vIG1hdHRlciB3aGV0aGVyCj4gPiBpdCdzIHNhdGlz Znlpbmcgb3Igbm90Lgo+ID4KPiA+Cj4gPiB0aGFua3MsCj4gPgo+ID4gVGFrYXNoaQo+IAo+IFNv IGxldCB1cyBkbyBzdGggaW4gdGhlIGhkYV9qYWNrLmMsIGFkZGluZyB0d28gbWVtYmVycyBjaGVj a19lbGQgYW5kCj4gZWxkX3ZhbGlkIGluIHRoZSBzdHJ1Y3QgaGRhX2phY2tfdGJse30sCj4gCj4g V2hlbiBidWlsZGluZyBuZXcgamFja3MsIHNpbmNlIHRoZXJlIGlzIG5vIGVsZF9kYXRhIHlldCwg anVzdCBmb2xsb3cKPiBvbGQgcnVsZXMgKG9ubHkgY2hlY2tpbmcgQUNfUElOU0VOU0VfUFJFU0VO Q0UpCj4gCj4gQWZ0ZXIgYnVpbGRpbmcgbmV3IGphY2tzLCBpZiBpdCBpcyBub3QgYSBwaGFudG9t IG9uZSwgc2V0IGNoZWNrX2VsZCB0byAxCj4gCj4gZXZlcnkgdGltZSB3ZSBnZXQgZWxkICh2aWEg dmVyYnMgb3IgYWNvbXApLCB3ZSB3aWxsIHN5bmMKPiBqYWNrLT5lbGRfdmFsaWQgdG8gZWxkLT5l bGRfdmFsaWQuCj4gCj4gaW4gdGhlIHJlcG9ydF9zeW5jKCksIHdlIHdpbGwgY2hlY2sgY2hlY2tf ZWxkIGFuZCBlbGRfdmFsaWQsIG5vdAo+IGRlcGVuZHMgb24gQUNfUElOU0VOU0VfUFJFU0VOQ0Ug b25seS4KPiAKPiBObyBtYXR0ZXIgaW50ZXJydXB0LCBzMyBvciBwb2xsLMKgIHRoZSBqYWNrLT5l bGRfdmFsaWQgd2lsbCBiZSBzeW5jZWQKPiBhbmQgdGhlIHJlcG9ydF9zeW5jKCkgd2lsbCByZXBv cnQgamFjayBzdGF0ZSBkZXBlbmVkcyBvbiBib3RoCj4gQUNfUElOU0VOU0VfUFJFU0VOQ0UgYW5k IGVsZF92YWxpZAo+IAo+IERvZXMgaXQgc291bmQgZ29vZD8KCk9LLCBJIHdhcyBjb25mdXNlZCAt LSBJIG92ZXJsb29rZWQgdGhlIGZhY3QgdGhhdCBoZGFfamFjay5jIHVwZGF0ZXMKdGhlIHBpbiBz ZW5zZSBsb2NhbGx5LiAgQW5kIHRoYW5rcyBmb3IgdGhlIHN1Z2dlc3Rpb24sIHdlJ3JlIGhlYWRp bmcKdG8gdGhlIHJpZ2h0IGRpcmVjdGlvbi4KCk9uZSB0aGluZyB0aGF0IGRvZXNuJ3QgZml0IGlz IGludHJvZHVjaW5nIEhETUktc3BlY2lmaWMgdGhpbmdzIGxpa2UKZWxkX3ZhbGlkIGFuZCBjaGVj a19lbGQuICBCYXNpY2FsbHkgdGhpcyBpcyBhYm91dCB0aGUgZmFsc2VseSByZXBvcnRlZApqYWNr IGRldGVjdGlvbiwgYWZ0ZXIgYWxsLiAgU28sIHdoYXQgd2UgbmVlZCBpcyB0aGUgY29ycmVjdGlv biBvZiB0aGUKaW5jb3JyZWN0IGphY2sgZGV0ZWN0aW9uIC0tIG9yIGEgd2F5IHRvIG92ZXJyaWRl IHRoZSB2YWx1ZS4KCkFjdHVhbGx5LCBmb3IgSERNSSwgdGhlcmUgaXMgbm8gcmVhc29uIHRvIHJl YWQgdGhlIHBpbiBzZW5zZSBhdCBhbGwuCkFsbCB3ZSBuZWVkIGlzIGFscmVhZHkgcHJvdmlkZWQg YnkgdGhlIEhETUkgY29kZWMgZHJpdmVyIChtb25pdG9yCnByZXNlbnQgYW5kIGVsZCB2YWxpZCku CgpUaGVuIEkgY2FuIHRoaW5rIG9mIGFkZGluZyBhIG5ldyBmbGFnIGhkYV9qYWNrX3RibC5tYW51 YWxfcGluX3NlbnNlLApmb3IgZXhhbXBsZSwgaW5kaWNhdGluZyB0aGF0IHRoZSBwaW4gc2Vuc2Ug aXMgdXBkYXRlZCBieSB0aGUgZHJpdmVyLgpUaGF0J3MgYSBjaGFuZ2Ugc29tZXRoaW5nIGxpa2Ug YmVsb3cuCgoKdGhhbmtzLAoKVGFrYXNoaQoKLS0tIGEvc291bmQvcGNpL2hkYS9oZGFfamFjay5j CisrKyBiL3NvdW5kL3BjaS9oZGEvaGRhX2phY2suYwpAQCAtMTg5LDcgKzE4OSw3IEBAIHZvaWQg c25kX2hkYV9qYWNrX3NldF9kaXJ0eV9hbGwoc3RydWN0IGhkYV9jb2RlYyAqY29kZWMpCiAJaW50 IGk7CiAKIAlmb3IgKGkgPSAwOyBpIDwgY29kZWMtPmphY2t0YmwudXNlZDsgaSsrLCBqYWNrKysp Ci0JCWlmIChqYWNrLT5uaWQpCisJCWlmIChqYWNrLT5uaWQgJiYgIWphY2stPm1hbnVhbF9waW5f c2Vuc2UpCiAJCQlqYWNrLT5qYWNrX2RpcnR5ID0gMTsKIH0KIEVYUE9SVF9TWU1CT0xfR1BMKHNu ZF9oZGFfamFja19zZXRfZGlydHlfYWxsKTsKQEAgLTU2OCw3ICs1NjgsOCBAQCB2b2lkIHNuZF9o ZGFfamFja191bnNvbF9ldmVudChzdHJ1Y3QgaGRhX2NvZGVjICpjb2RlYywgdW5zaWduZWQgaW50 IHJlcykKIAlldmVudCA9IHNuZF9oZGFfamFja190YmxfZ2V0X2Zyb21fdGFnKGNvZGVjLCB0YWcp OwogCWlmICghZXZlbnQpCiAJCXJldHVybjsKLQlldmVudC0+amFja19kaXJ0eSA9IDE7CisJaWYg KCFldmVudC0+bWFudWFsX3Bpbl9zZW5zZSkKKwkJZXZlbnQtPmphY2tfZGlydHkgPSAxOwogCiAJ Y2FsbF9qYWNrX2NhbGxiYWNrKGNvZGVjLCByZXMsIGV2ZW50KTsKIAlzbmRfaGRhX2phY2tfcmVw b3J0X3N5bmMoY29kZWMpOwotLS0gYS9zb3VuZC9wY2kvaGRhL2hkYV9qYWNrLmgKKysrIGIvc291 bmQvcGNpL2hkYS9oZGFfamFjay5oCkBAIC00MCw2ICs0MCw3IEBAIHN0cnVjdCBoZGFfamFja190 YmwgewogCXVuc2lnbmVkIGludCBqYWNrX2RpcnR5OjE7CS8qIG5lZWRzIHRvIHVwZGF0ZT8gKi8K IAl1bnNpZ25lZCBpbnQgcGhhbnRvbV9qYWNrOjE7ICAgIC8qIGEgZml4ZWQsIGFsd2F5cyBwcmVz ZW50IHBvcnQ/ICovCiAJdW5zaWduZWQgaW50IGJsb2NrX3JlcG9ydDoxOyAgICAvKiBpbiBhIHRy YW5zaXRpb25hbCBzdGF0ZSAtIGRvIG5vdCByZXBvcnQgdG8gdXNlcnNwYWNlICovCisJdW5zaWdu ZWQgaW50IG1hbnVhbF9waW5fc2Vuc2U6MTsgLyogcGluX3NlbnNlIGlzIHVwZGF0ZWQgYnkgY29k ZWMgZHJpdmVyICovCiAJaGRhX25pZF90IGdhdGluZ19qYWNrOwkJLyogdmFsaWQgd2hlbiBnYXRp bmcgamFjayBwbHVnZ2VkICovCiAJaGRhX25pZF90IGdhdGVkX2phY2s7CQkvKiBnYXRlZCBpcyBk ZXBlbmRlbnQgb24gdGhpcyBqYWNrICovCiAJaW50IHR5cGU7Ci0tLSBhL3NvdW5kL3BjaS9oZGEv cGF0Y2hfaGRtaS5jCisrKyBiL3NvdW5kL3BjaS9oZGEvcGF0Y2hfaGRtaS5jCkBAIC0xNzAsNiAr MTcwLDcgQEAgc3RydWN0IGhkbWlfc3BlYyB7CiAKIAlib29sIGR5bl9waW5fb3V0OwogCWJvb2wg ZHluX3BjbV9hc3NpZ247CisJYm9vbCB1c2VfcGluX3NlbnNlOwogCS8qCiAJICogTm9uLWdlbmVy aWMgVklBL05WSURJQSBzcGVjaWZpYwogCSAqLwpAQCAtNzk3LDcgKzc5OCw2IEBAIHN0YXRpYyB2 b2lkIGhkbWlfaW50cmluc2ljX2V2ZW50KHN0cnVjdCBoZGFfY29kZWMgKmNvZGVjLCB1bnNpZ25l ZCBpbnQgcmVzKQogCWphY2sgPSBzbmRfaGRhX2phY2tfdGJsX2dldF9mcm9tX3RhZyhjb2RlYywg dGFnKTsKIAlpZiAoIWphY2spCiAJCXJldHVybjsKLQlqYWNrLT5qYWNrX2RpcnR5ID0gMTsKIAog CWNvZGVjX2RiZyhjb2RlYywKIAkJIkhETUkgaG90IHBsdWcgZXZlbnQ6IENvZGVjPSVkIFBpbj0l ZCBEZXZpY2U9JWQgSW5hY3RpdmU9JWQgUHJlc2VuY2VfRGV0ZWN0PSVkIEVMRF9WYWxpZD0lZFxu IiwKQEAgLTE1NTEsOCArMTU1MSwxMSBAQCBzdGF0aWMgYm9vbCBoZG1pX3ByZXNlbnRfc2Vuc2Vf dmlhX3ZlcmJzKHN0cnVjdCBoZG1pX3NwZWNfcGVyX3BpbiAqcGVyX3BpbiwKIAlyZXQgPSAhcmVw b2xsIHx8ICFlbGQtPm1vbml0b3JfcHJlc2VudCB8fCBlbGQtPmVsZF92YWxpZDsKIAogCWphY2sg PSBzbmRfaGRhX2phY2tfdGJsX2dldChjb2RlYywgcGluX25pZCk7Ci0JaWYgKGphY2spCisJaWYg KGphY2spIHsKIAkJamFjay0+YmxvY2tfcmVwb3J0ID0gIXJldDsKKwkJamFjay0+cGluX3NlbnNl ID0gKGVsZC0+bW9uaXRvcl9wcmVzZW50ICYmIGVsZC0+ZWxkX3ZhbGlkKSA/CisJCQlBQ19QSU5T RU5TRV9QUkVTRU5DRSA6IDA7CisJfQogCiAJbXV0ZXhfdW5sb2NrKCZwZXJfcGluLT5sb2NrKTsK IAlyZXR1cm4gcmV0OwpAQCAtMjE2Myw2ICsyMTY2LDcgQEAgc3RhdGljIGludCBnZW5lcmljX2hk bWlfYnVpbGRfamFjayhzdHJ1Y3QgaGRhX2NvZGVjICpjb2RlYywgaW50IHBjbV9pZHgpCiAJICog YWxpZ24gd2l0aCBkeW5fcGNtX2Fzc2lnbiBtb2RlCiAJICovCiAJc3BlYy0+cGNtX3JlY1twY21f aWR4XS5qYWNrID0gamFjay0+amFjazsKKwlqYWNrLT5tYW51YWxfcGluX3NlbnNlID0gIXNwZWMt PnVzZV9waW5fc2Vuc2U7CiAJcmV0dXJuIDA7CiB9CiAKQEAgLTI5NzIsNiArMjk3Niw3IEBAIHN0 YXRpYyBpbnQgcGF0Y2hfc2ltcGxlX2hkbWkoc3RydWN0IGhkYV9jb2RlYyAqY29kZWMsCiAJc3Bl Yy0+bXVsdGlvdXQuZGlnX291dF9uaWQgPSBjdnRfbmlkOwogCXNwZWMtPm51bV9jdnRzID0gMTsK IAlzcGVjLT5udW1fcGlucyA9IDE7CisJc3BlYy0+dXNlX3Bpbl9zZW5zZSA9IHRydWU7CiAJcGVy X3BpbiA9IHNuZF9hcnJheV9uZXcoJnNwZWMtPnBpbnMpOwogCXBlcl9jdnQgPSBzbmRfYXJyYXlf bmV3KCZzcGVjLT5jdnRzKTsKIAlpZiAoIXBlcl9waW4gfHwgIXBlcl9jdnQpIHsKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KQWxzYS1kZXZlbCBtYWlsaW5n IGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHBzOi8vbWFpbG1hbi5hbHNhLXBy b2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8vYWxzYS1kZXZlbAo=