All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Wischer, Timo (ADITG/ESB)" <twischer@de.adit-jv.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH - IOPLUG DRAIN 0/2]
Date: Thu, 22 Mar 2018 17:22:49 +0100	[thread overview]
Message-ID: <s5hin9oozae.wl-tiwai@suse.de> (raw)
In-Reply-To: <B0FB33DC1499054591F62C0EF1E013D7684FE3E2@HI2EXCH01.adit-jv.com>

On Thu, 22 Mar 2018 16:17:10 +0100,
Wischer, Timo (ADITG/ESB) wrote:
> 
> > I don't understand.  The pulse plugin calls pa_stream_drain(), and
> > pulse_wait_operation() to wait until the drain finishes.  What does it
> > have to do with threading?
> 
> As far as I understand you patch io->data->callback->drain() will not be called in nonblocking mode.
> +       if (io->data->state == SND_PCM_STATE_DRAINING) {
> +               if (io->data->nonblock)
> +                       return -EAGAIN;
> +
> +               if (io->data->callback->drain) {
> +                       err = io->data->callback->drain(io->data);
> +                       if (err < 0)
> +                               return err;
> +               }
> +       }
> 
> Therefore how should call pa_stream_drain() in case of nonblocking mode?

The application needs to sync manually via poll() instead.
It's also the behavior of the kernel driver, which ioplug follows.


Takashi

  reply	other threads:[~2018-03-22 16:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-22 13:48 [PATCH - IOPLUG DRAIN 0/2] twischer
2018-03-22 13:48 ` [PATCH - IOPLUG DRAIN 1/1] ioplug: drain: Wait with pollwhen EAGAIN in blocking mode twischer
2018-03-22 13:48 ` [PATCH - IOPLUG DRAIN 1/1] jack: Support snd_pcm_drain() twischer
2018-03-22 14:28 ` [PATCH - IOPLUG DRAIN 0/2] Takashi Iwai
2018-03-22 14:50   ` Wischer, Timo (ADITG/ESB)
2018-03-22 14:55     ` Takashi Iwai
2018-03-22 15:17       ` Wischer, Timo (ADITG/ESB)
2018-03-22 16:22         ` Takashi Iwai [this message]
2018-03-23  7:23           ` Wischer, Timo (ADITG/ESB)
2018-03-23  7:28             ` Takashi Iwai
2018-03-23  7:43               ` Wischer, Timo (ADITG/ESB)
2018-03-23  8:01                 ` Takashi Iwai
2018-03-23  8:08                   ` Takashi Iwai
2018-03-23  9:03                     ` Takashi Iwai
2018-03-28  8:42                       ` Wischer, Timo (ADITG/ESB)
2018-03-28 16:09                         ` Takashi Iwai
2018-03-29  6:39                           ` Wischer, Timo (ADITG/ESB)
2018-03-29  7:25                             ` Takashi Iwai
2018-03-29  7:38                               ` Wischer, Timo (ADITG/ESB)
2018-03-23  8:21                   ` Wischer, Timo (ADITG/ESB)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hin9oozae.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=twischer@de.adit-jv.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.