From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH] ALSA: hda: Fix forget to free resource in error handling code path in hda_codec_driver_probe Date: Sun, 03 Sep 2017 16:36:48 +0200 Message-ID: References: <20170903141122.GA2848@udknight> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20170903141122.GA2848@udknight> Sender: linux-kernel-owner@vger.kernel.org To: Wang YanQing Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Sun, 03 Sep 2017 16:11:22 +0200, Wang YanQing wrote: > > When hda_codec_driver_probe meet error and return failure, we need > to free resource with patch_ops.free, or we will get resource leak. No, the codec driver is responsible to free resources in its error path. thanks, Takashi