From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1034908AbcIZMek (ORCPT <rfc822;w@1wt.eu>);
        Mon, 26 Sep 2016 08:34:40 -0400
Received: from mx2.suse.de ([195.135.220.15]:57793 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1034089AbcIZMef (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 26 Sep 2016 08:34:35 -0400
Date: Mon, 26 Sep 2016 14:34:33 +0200
Message-ID: <s5hintideli.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Zefan Li <lizefan@huawei.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH 4.4 048/118] cpuset: make sure new tasks conform to the current config of the cpuset
In-Reply-To: <20160922172941.226931424@linuxfoundation.org>
References: <20160922172938.643879685@linuxfoundation.org>
        <20160922172941.226931424@linuxfoundation.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 22 Sep 2016 19:29:08 +0200,
Greg Kroah-Hartman wrote:
> 
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Zefan Li <lizefan@huawei.com>
> 
> commit 06f4e94898918bcad00cdd4d349313a439d6911e upstream.
> 
> A new task inherits cpus_allowed and mems_allowed masks from its parent,
> but if someone changes cpuset's config by writing to cpuset.cpus/cpuset.mems
> before this new task is inserted into the cgroup's task list, the new task
> won't be updated accordingly.
> 
> Signed-off-by: Zefan Li <lizefan@huawei.com>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> ---
>  kernel/cpuset.c |   15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> --- a/kernel/cpuset.c
> +++ b/kernel/cpuset.c
> @@ -2074,6 +2074,20 @@ static void cpuset_bind(struct cgroup_su
>  	mutex_unlock(&cpuset_mutex);
>  }
>  
> +/*
> + * Make sure the new task conform to the current state of its parent,
> + * which could have been changed by cpuset just after it inherits the
> + * state from the parent and before it sits on the cgroup's task list.
> + */
> +void cpuset_fork(struct task_struct *task)

This causes a build warning:

  kernel/cpuset.c:2101:2: warning: (near initialization for 'cpuset_cgrp_subsys.fork') [enabled by default]
  .fork  = cpuset_fork,
  ^

where fork op in 4.4 kernel has still priv argument that was dropped
recently.


Takashi