From mboxrd@z Thu Jan  1 00:00:00 1970
From: Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v1] ALSA: hda- Add headset mic pin quirk
	for a Dell device
Date: Fri, 24 Jul 2015 08:54:08 +0200
Message-ID: <s5hio9avyen.wl-tiwai@suse.de>
References: <1437713442-6061-1-git-send-email-woodrow.shen@canonical.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from mx2.suse.de (mx2.suse.de [195.135.220.15])
 by alsa0.perex.cz (Postfix) with ESMTP id D78FE260557
 for <alsa-devel@alsa-project.org>; Fri, 24 Jul 2015 08:54:09 +0200 (CEST)
In-Reply-To: <1437713442-6061-1-git-send-email-woodrow.shen@canonical.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: woodrow.shen@canonical.com
Cc: alsa-devel@alsa-project.org, david.henningsson@canonical.com, 1475553@bugs.launchpad.net
List-Id: alsa-devel@alsa-project.org

On Fri, 24 Jul 2015 06:50:42 +0200,
woodrow.shen@canonical.com wrote:
> 
> From: Woodrow Shen <woodrow.shen@canonical.com>
> 
> Fix the headset mic that will not work on Dell desktop machine.
> BugLink: https://bugs.launchpad.net/bugs/1475553
> Signed-off-by: Woodrow Shen <woodrow.shen@canonical.com>

I have repeatedly received patches with the very same subject and with
the very similar content but without further explanation.  It's too
confusing.

Please look through the git commit history of this file, and re-read
your patch.  Then, consider a more useful subject / description, and
resubmit the patch.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 742fc62..d94c0e3 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5473,6 +5473,28 @@ static const struct snd_hda_pin_quirk alc269_pin_fixup_tbl[] = {
>  		{0x1e, 0x411111f0},
>  		{0x21, 0x0221103f}),
>  	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0x40000000},
> +		{0x14, 0x90170150},
> +		{0x17, 0x411111f0},
> +		{0x18, 0x411111f0},
> +		{0x19, 0x411111f0},
> +		{0x1a, 0x411111f0},
> +		{0x1b, 0x02011020},
> +		{0x1d, 0x4054c029},
> +		{0x1e, 0x411111f0},
> +		{0x21, 0x0221105f}),
> +	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
> +		{0x12, 0x40000000},
> +		{0x14, 0x90170110},
> +		{0x17, 0x411111f0},
> +		{0x18, 0x411111f0},
> +		{0x19, 0x411111f0},
> +		{0x1a, 0x411111f0},
> +		{0x1b, 0x01014020},
> +		{0x1d, 0x4054c029},
> +		{0x1e, 0x411111f0},
> +		{0x21, 0x0221101f}),
> +	SND_HDA_PIN_QUIRK(0x10ec0255, 0x1028, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE,
>  		{0x12, 0x90a60160},
>  		{0x14, 0x90170120},
>  		{0x17, 0x90170140},
> -- 
> 2.1.4
>