From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: Oops in sound/usb/pcm.c:match_endpoint_audioformats() in current -git Date: Fri, 11 Jan 2013 11:17:43 +0100 Message-ID: References: <50EE7A94.60409@kernel.dk> <50EEB8D2.2030702@kernel.dk> <50EFC38D.80306@kernel.dk> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <50EFC38D.80306@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org To: Jens Axboe Cc: Eldad Zack , perex@perex.cz, alsa-devel@alsa-project.org, "linux-kernel@vger.kernel.org" List-Id: alsa-devel@alsa-project.org At Fri, 11 Jan 2013 08:47:25 +0100, Jens Axboe wrote: > > On 2013-01-10 21:19, Takashi Iwai wrote: > > From: Takashi Iwai > > Subject: [PATCH v2] ALSA: usb-audio: Fix NULL dereference by access to > > non-existing substream > > > > The commit [0d9741c0: ALSA: usb-audio: sync ep init fix for > > audioformat mismatch] introduced the correction of parameters to be > > set for sync EP. But since the new code assumes that the sync EP is > > always paired with the data EP of another direction, it triggers Oops > > when a device only with a single direction is used. > > > > This patch adds a proper check of sync EP type and the presence of the > > paired substream for avoiding the crash. > > > > Reported-by: Jens Axboe > > Signed-off-by: Takashi Iwai > > Confirmed, it works. You can add my tested-by too. Thanks Takashi! Thanks for quick testing. Applied it now. Takashi