From: Takashi Iwai <tiwai@suse.de>
To: John Kacur <jkacur@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Jonathan Corbet <corbet@lwn.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Vincent^M^J Sanders <vince@simtec.co.uk>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] sound_core.c: Remove BKL from soundcore_open
Date: Mon, 12 Oct 2009 08:05:51 +0200 [thread overview]
Message-ID: <s5hiqelf8ow.wl%tiwai@suse.de> (raw)
In-Reply-To: <alpine.LFD.2.00.0910111437270.3587@localhost.localdomain>
At Sun, 11 Oct 2009 14:41:15 +0200 (CEST),
John Kacur wrote:
>
> @@ -631,17 +629,17 @@ static int soundcore_open(struct inode *inode, struct file *file)
> file->f_op = new_fops;
> spin_unlock(&sound_loader_lock);
> if(file->f_op->open)
> + lock_kernel();
> err = file->f_op->open(inode,file);
> + unlock_kernel();
You certainly want braces around here, no?
Takashi
next prev parent reply other threads:[~2009-10-12 6:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 23:24 [PATCH] sound_core.c: Remove BKL from soundcore_open John Kacur
2009-10-10 23:42 ` Alan Cox
2009-10-11 0:25 ` John Kacur
2009-10-11 11:33 ` Frederic Weisbecker
2009-10-11 12:41 ` John Kacur
2009-10-11 14:12 ` Oliver Neukum
2009-10-11 20:40 ` Frederic Weisbecker
2009-10-11 21:25 ` John Kacur
2009-10-12 6:05 ` Takashi Iwai [this message]
2009-10-12 8:37 ` John Kacur
2009-10-12 10:17 ` Takashi Iwai
2009-10-12 10:42 ` John Kacur
2009-10-11 15:20 ` Jonathan Corbet
2009-10-11 17:15 ` Jonathan Corbet
2009-10-11 17:37 ` Arjan van de Ven
2009-10-11 19:17 ` Alan Cox
2009-10-11 19:26 ` Arjan van de Ven
2009-10-11 20:51 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hiqelf8ow.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=corbet@lwn.net \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=vince@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.