From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH/RFC] emu10k1 multichannel PCM Date: Wed, 17 Nov 2004 14:44:10 +0100 Message-ID: References: <1100300857.19038.14.camel@krustophenia.net> <1100405924.16103.23.camel@krustophenia.net> <1100672577.5832.7.camel@krustophenia.net> Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1100672577.5832.7.camel@krustophenia.net> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Lee Revell Cc: alsa-devel List-Id: alsa-devel@alsa-project.org At Wed, 17 Nov 2004 01:22:56 -0500, Lee Revell wrote: > > [1 ] > On Sat, 2004-11-13 at 23:18 -0500, Lee Revell wrote: > > On Fri, 2004-11-12 at 18:07 -0500, Lee Revell wrote: > > > This patch is still missing a few things, like dynamic voice allocation > > > and correctly setting the send routing, but it does work with JACK, and > > > should not interfere with the operation of the other devices. I tested > > > it like so: > > > > Here is a patch that adds the mixer controls for this device. > > Here is the latest version. This fixes the send routing and mixer > controls. Among other things there was a copy and paste bug in > emumixer.c. > > I have tested this one with JACK and Hydrogen, it actually works better > at 64 frames than it did with separate capture/playback interrupts. > > The patch is up to 1200 lines or so. It should not get much longer. > There are still some bugs; this is not ready to commit yet but getting > close. > > Signed-Off-By: Lee Revell We still need to discuss the mixer handling, but otherwise the implementation seems ok to me. The code looks alsmot fine. Please keep the 8-letter tab stop for indentation, and be careful about the compatibility with the older gcc such as variable definition in the middle of the function. I expect that debug prints will be eliminated in the final version, right? Takashi ------------------------------------------------------- This SF.Net email is sponsored by: InterSystems CACHE FREE OODBMS DOWNLOAD - A multidimensional database that combines robust object and relational technologies, making it a perfect match for Java, C++,COM, XML, ODBC and JDBC. www.intersystems.com/match8