Re: [RFC] Echoaudio driver

[Takashi Iwai <tiwai@suse.de>]

At Sat, 9 Oct 2004 00:04:45 +0200,
Giuliano Pochini wrote:
> 
> On Fri, 08 Oct 2004 16:47:52 +0200
> Takashi Iwai <tiwai@suse.de> wrote:
> 
> > > > In the case of au88x0, it was hard to merge because they use different
> > > > addresses in each chip, while echo boards seem to have the same
> > > > register offsets, right?
> > > > But I don't insist on this rewrite if you prefer keeping this, of
> > > > course.
> > >
> > > Most of the #ifdef's are used to exclude unused controls. Those parts can be
> > > moved into separate files and included from <card>.c just like the other
> > > parts. snd_ctl_add() calls will remain inside conditionals anyway.
> >
> > Sounds better (unless this results in too many files :)
> 
> 8 new files... And I'm not sure it looks better than before.
> 
> http://xoomer.virgilio.it/g_pochini/ea-0.9.0.tar.bz2

Well, I'm also not sure :)
Choose as you like for the initial release.  We can clean up later
on.


> > About the firmware: since the recent 2.4 kernel also includes
> > request_firmware(), it's the easiest way to go, I believe.
> >
> > I'll rewrite the firmware code later for other drivers.  I'll likely
> > keep the old implementation of ALSA firmware loader for the cases that
> > no kernel fw-loader is configured or the driver is built in kernel.
> >
> > If you finish them, please send me the patch.
> 
> I've not written the firmware loader yet. I'll do it during the week end.

Thanks.


Takashi


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl