Re: Problems with VIA8233A (todays cvs)

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

At Wed, 23 Jul 2003 14:58:22 +0200,
Joerg Mayer wrote:
> 
> Oh, btw. I have some doubts that the chipset really is a 8233A chipset (the A).

grrr, i overlooked that your chip is revision A.  sorry.
that explains why dxs_support options don't work: it's for 8233/8235
only but not 8233A.  (8233A has no DXS channels.)

could you try the attached patch for tests?
i don't expect much that this will solve the problem, but to be
sure...

if it's still too fast, it might be the ac97 clock problem like in
intel8x0 driver.  please try to set a lower value to ac97_clock module
option, such as 41200.


Takashi

[-- Attachment #2: via-check.dif --]
[-- Type: application/octet-stream, Size: 1216 bytes --]

Index: alsa-kernel/pci/via82xx.c
===================================================================
RCS file: /suse/tiwai/cvs/alsa/alsa-kernel/pci/via82xx.c,v
retrieving revision 1.49
diff -u -r1.49 via82xx.c
--- alsa-kernel/pci/via82xx.c	21 Jul 2003 14:54:26 -0000	1.49
+++ alsa-kernel/pci/via82xx.c	23 Jul 2003 13:04:57 -0000
@@ -886,9 +886,11 @@
 		snd_ac97_set_rate(chip->ac97, AC97_PCM_LFE_DAC_RATE, runtime->rate);
 		snd_ac97_set_rate(chip->ac97, AC97_SPDIF, runtime->rate);
 	}
+#if 0
 	if (chip->revision == VIA_REV_8233A)
 		rbits = 0;
 	else
+#endif
 		rbits = (0xfffff / 48000) * runtime->rate + ((0xfffff % 48000) * runtime->rate) / 48000;
 	snd_assert((rbits & ~0xfffff) == 0, return -EINVAL);
 	snd_via82xx_channel_reset(chip, viadev);
@@ -928,9 +930,12 @@
 	fmt = (runtime->format == SNDRV_PCM_FORMAT_S16_LE) ? VIA_REG_MULTPLAY_FMT_16BIT : VIA_REG_MULTPLAY_FMT_8BIT;
 	fmt |= runtime->channels << 4;
 	outb(fmt, VIADEV_REG(viadev, OFS_MULTPLAY_FORMAT));
+#if 0
 	if (chip->revision == VIA_REV_8233A)
 		slots = 0;
-	else {
+	else
+#endif
+	{
 		/* set sample number to slot 3, 4, 7, 8, 6, 9 (for VIA8233/C,8235) */
 		/* corresponding to FL, FR, RL, RR, C, LFE ?? */
 		switch (runtime->channels) {