Re: [PATCH 16/17] ASoC: Basic split of mpc5200 DMA code out from mpc5200_psc_i2s

[Takashi Iwai <tiwai@suse.de>]

At Tue, 28 Apr 2009 20:53:53 +0100,
Mark Brown wrote:
> 
> On Tue, Apr 28, 2009 at 09:37:34PM +0200, Takashi Iwai wrote:
> 
> > Also, we need to reconsider which of you change is really needed
> > since the current problem of the PCM will be solved in the PCM
> > core side soon later without the change of the driver side.
> 
> AFAICT all the currently posted patches are needed since they're only
> doing the refactoring of the code required to support AC97.  They're
> only related to the fixes in that John's board doesn't have I2S but
> since the DMA is shared the fixes that John develops while making AC97
> work will also fix I2S.

OK.  I thought that he rewrote the pointer callback to return
jiffies-based values and it could be superfluous.  Other than that,
it should be all fine.

Basically I don't mind to merge Jon's patch series now for 2.6.31 once
after the current merge conflicts are resolved.
There won't be many changes on 2.6.30 for that driver any more.
At most, a patch will be just to remove BROKEN from kconfig again
(hopefully in time).


Takashi