Re: Phase 22 patch

[Takashi Iwai <tiwai@suse.de>]

At Mon, 07 Feb 2005 22:03:35 -0500,
Misha Jiline wrote:
> 
> I've struggled for a couple of days with Terratec Phase 22 card. Chips used on it are
> well known but the combination is somehow unique. Phase 88 should have been similar...
> but it actually uses 1712 instead of 1721 (Envy24HT-S). So here is the patch against
> release 1.0.8 that adds Phase 22 to ice1724. I've tested only analog part (balances 1/
> 4 TRS in and outs).
> 
> I hope maintainers will ok it to be included to the mainstream.

Thanks, the patch looks fine.

Only subtle things:

> +/*
> + *   ALSA driver for ICEnsemble ICE1724 (Envy24)
> + *
> + *   Lowlevel functions for Terratec PHASE 22
> + *
> + *	Copyright (c) 2003 Misha Zhilin <misha@epiphan.com>

Is the code really so old?  :)

> +	ak = ice->akm = kmalloc(sizeof(akm4xxx_t), GFP_KERNEL);

Safer to use kcalloc() here.

Could you fix thte above and regenerate the patch against CVS version?
The ice1712 code was slightly changed since 1.0.8 due to addition of
Juli board support.

Also, please give "Signed-off-by" to add your credit in changelog
(it's required for submitting to linux kernel).


thanks,

Takashi


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click