Re: [PATCH - attached this time] azx/realtek: Cleanup of the W810 system support.

[Takashi Iwai <tiwai@suse.de>]

At Wed, 5 Jan 2005 12:40:41 -0800,
Stephen Warren wrote:
> 
> Clean-ups of the W810 support in azx/patch_realtek.c
> 
> * Correctly size a couple of static data arrays.
> 
> * Fix alc880_ch_mode_get so it only accesses index 0 of
> spec->channel_mode,
>   in case there's only one entry.
> 
> * Add separate mute switch for headphone/speaker output pin of the W810
> 
> * Set all amps to be zero-volume, and pins to be muted, in the
> initialization
>   verb sequence, like a standard ALSA driver.
> 
> * Enable SPDIF object creation (set dig_out_nid)
> 
> * Fix a lot of W810-specific comments to be more accurate.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>

Thanks, the patch is now on CVS.

In addition to your original patch, I changed
alc880_w810_modes.sequence from 0 to NULL.
Also, added the NULL check of sequence pointer, just to be sure.


> I hadn't realized that I'd included W810 support in my previous patch -
> I'd meant to send that in later! This patch cleans up some of the
> work-in-progress.

Don't worry, it's still in rc phase :)

> DAC NID 0x02 is routed to both pin NID 0x14 (rear jack named "front")
> and to pin NID 0x1b (connected to internal speakers, and headphone
> jack). I've created a mixer element named "Headphone Playback Switch" to
> allow the control of the mute for pin NID 0x1b. Is this the right way to
> do this? Thanks for feedback.

It looks fine...


Takashi


-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt