From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Iwai Subject: Re: [PATCH v2] ALSA: usb-audio: fix Line6 Helix audio format rates Date: Sun, 07 Jul 2019 11:27:20 +0200 Message-ID: References: <20190707082734.25829-1-nick83ola@gmail.com> Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190707082734.25829-1-nick83ola@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Nicola Lunghi Cc: alsa-devel@alsa-project.org, Thomas Gleixner , Greg Kroah-Hartman , Allison Randal , Jaroslav Kysela , Jussi Laako , linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Sun, 07 Jul 2019 10:27:34 +0200, Nicola Lunghi wrote: > @@ -294,7 +321,7 @@ static int parse_audio_format_rates_v2v3(struct snd_usb_audio *chip, > { > struct usb_device *dev = chip->dev; > unsigned char tmp[2], *data; > - int nr_triplets, data_size, ret = 0; > + int nr_triplets, data_size, ret, ret_l6 = 0; This caused a compile warning: sound/usb/format.c: In function ‘parse_audio_format_rates_v2v3’: sound/usb/format.c:337:30: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] int nr_triplets, data_size, ret, ret_l6 = 0; ^~~ So I applied with a fix, keeping ret = 0 while dropping the superfluous zero initialization for ret_l6. thanks, Takashi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDE63C0650E for ; Sun, 7 Jul 2019 09:27:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEF922064B for ; Sun, 7 Jul 2019 09:27:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727260AbfGGJ1Z (ORCPT ); Sun, 7 Jul 2019 05:27:25 -0400 Received: from mx2.suse.de ([195.135.220.15]:42934 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725822AbfGGJ1Z (ORCPT ); Sun, 7 Jul 2019 05:27:25 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 2CBEDAB98; Sun, 7 Jul 2019 09:27:21 +0000 (UTC) Date: Sun, 07 Jul 2019 11:27:20 +0200 Message-ID: From: Takashi Iwai To: "Nicola Lunghi" Cc: , "Thomas Gleixner" , "Greg Kroah-Hartman" , "Allison Randal" , "Jaroslav Kysela" , "Jussi Laako" , Subject: Re: [PATCH v2] ALSA: usb-audio: fix Line6 Helix audio format rates In-Reply-To: <20190707082734.25829-1-nick83ola@gmail.com> References: <20190707082734.25829-1-nick83ola@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 07 Jul 2019 10:27:34 +0200, Nicola Lunghi wrote: > @@ -294,7 +321,7 @@ static int parse_audio_format_rates_v2v3(struct snd_usb_audio *chip, > { > struct usb_device *dev = chip->dev; > unsigned char tmp[2], *data; > - int nr_triplets, data_size, ret = 0; > + int nr_triplets, data_size, ret, ret_l6 = 0; This caused a compile warning: sound/usb/format.c: In function ‘parse_audio_format_rates_v2v3’: sound/usb/format.c:337:30: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized] int nr_triplets, data_size, ret, ret_l6 = 0; ^~~ So I applied with a fix, keeping ret = 0 while dropping the superfluous zero initialization for ret_l6. thanks, Takashi