Re: [PATCH 09/14] drm/mgag200: Add missing drm_connector_unregister()

[Takashi Iwai <tiwai@suse.de>]

On Tue, 18 Jul 2017 16:43:15 +0200,
Takashi Iwai wrote:
> 
> From: Egbert Eich <eich@suse.de>
> 
> When destroying connector unregister it.
> 
> Signed-off-by: Egbert Eich <eich@suse.de>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>

This one should be also superfluous as Daniel pointed for the similar
patch for cirrus.  Please disregard this one.


BTW, I guess the patch was inspired from ast driver code, but then it
implies that the call in ast_mode.c is also superfluous.
Shall I cook up a patch?


thanks,

Takashi

> ---
>  drivers/gpu/drm/mgag200/mgag200_mode.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index ba7ee93b57a9..7c8e3c6ace0b 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -1796,6 +1796,7 @@ static void mga_connector_destroy(struct drm_connector *connector)
>  {
>  	struct mga_connector *mga_connector = to_mga_connector(connector);
>  	mgag200_i2c_destroy(mga_connector->i2c);
> +	drm_connector_unregister(connector);
>  	drm_connector_cleanup(connector);
>  	kfree(connector);
>  }
> -- 
> 2.13.2
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel