All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH v2 00/10]  audio timestamping evolutions
Date: Fri, 26 Dec 2014 12:12:55 +0100	[thread overview]
Message-ID: <s5hlhluis08.wl-tiwai@suse.de> (raw)
In-Reply-To: <5496C7C2.5060406@perex.cz>

At Sun, 21 Dec 2014 14:14:42 +0100,
Jaroslav Kysela wrote:
> 
> Dne 19.12.2014 v 22:17 Pierre-Louis Bossart napsal(a):
> > Thanks for the review Jaroslav
> > 
> >> 1) ext_info member is not required - the standard info field
> >>     has enough free bits
> > 
> > Well this was added at Takashi's request, the initial patches didn't 
> > rely on this extension...I can roll back those changes if this is the 
> > consensus.
> 
> Yes, every developer has it's own opinions.. I would just not to add
> next field until the all bits are not used.

This was what we thought at first.  But later on, I found that it's a
bit ugly.  Namely, assume you'll add more tstamp types to be
advertised in INFO bit, but we already add yet another irrelevant bit
beforehand.  Then the whole type bits will become sparse.

Since this is a (possibly) extensible bitmask, having it separately
would make sense.

Though, I have no strong opinion on this.  If you have a good counter
argument, I'll be your ears :)


thanks,

Takashi

  reply	other threads:[~2014-12-26 11:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 17:25 [PATCH v2 00/10] audio timestamping evolutions Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 01/10] ALSA: core: don't override timestamp unconditionally Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 02/10] ALSA: core: allow for trigger_tstamp snapshot in .trigger Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 03/10] ALSA: hda: read trigger_timestamp immediately after starting DMA Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 04/10] ALSA: usb: update trigger timestamp on first non-zero URB submitted Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 05/10] ALSA: core: add info_ext field in hw_params and pcm_hardware Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 06/10] ALSA: core: selection of audio_tstamp type and accuracy reports Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 07/10] ALSA: core: pass audio tstamp config from userspace Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 08/10] ALSA: core: pass audio tstamp config from userspace in compat mode Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 09/10] ALSA: core: replace .wall_clock by .get_time_info Pierre-Louis Bossart
2014-12-19 17:25 ` [PATCH v2 10/10] ALSA: hda: replace .wallclock " Pierre-Louis Bossart
2014-12-20  6:07   ` Raymond Yau
2014-12-20 17:50     ` Pierre-Louis Bossart
2014-12-19 20:38 ` [PATCH v2 00/10] audio timestamping evolutions Jaroslav Kysela
2014-12-19 21:17   ` Pierre-Louis Bossart
2014-12-21 13:14     ` Jaroslav Kysela
2014-12-26 11:12       ` Takashi Iwai [this message]
2015-01-05 21:11       ` Pierre-Louis Bossart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hlhluis08.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.